Refactor: BLF Use Vector for Glyph Cache List #118174
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#118174
Loading…
Reference in New Issue
No description provided.
Delete Branch "Harley/blender:BlfGlyphCacheList"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Replace FontBLF's ListBase with a GlyphCacheListBLF class that uses a
blender::Vector of GlyphCacheBLF, holds the std::mutex, has methods for
acquire, release, clear. Seems like a simple first step.
I like this iteration, the diff looks very simple.
@ -171,0 +148,4 @@
GlyphCacheBLF *gc = nullptr;
for (auto &entry : list) {
Typically we don't use
auto
unless the type name is already written on a line (for example with casting) or it's actually not possible to write concretely. That's because it's helpful information to the reader who would have to look elsewhere otherwise.@ -107,2 +109,4 @@
} KerningCacheBLF;
class GlyphCacheListBLF {
private:
private
is redundant for classes which are private by default@ -108,1 +110,4 @@
class GlyphCacheListBLF {
private:
std::vector<GlyphCacheBLF *> list;
blender::Vector
is generally preferable since it has methods to work better with other Blender containers, and it has an inline buffer to avoid allocations for small numbers of elements@ -109,0 +115,4 @@
FontBLF *font;
/** Mutex lock for glyph cache. */
ThreadMutex glyph_cache_mutex;
It would probably be simpler/easy to switch to
std::mutex
now too :)Yes, I thought it best start with just this glyph cache list first to make sure that I'm doing it right.
Thanks! Done.
@ -108,1 +112,4 @@
class GlyphCacheListBLF {
blender::Vector<GlyphCacheBLF *> list;
FontBLF *font;
Sorry, I didn't realize this pointer here as the resolution to the need to pass "font" to the functions. I'll propose an alternative change to see what you think
Hans Goudey referenced this pull request2024-02-13 21:43:47 +01:00
Closing. Done better in Hans' #118222
Pull request closed