USD: Fix varying interpolation import #118539

Merged

This addresses issue #93052.

Now converting the USD "varying" interpolation type to
the "point" domain type when importing USD attributes.

There have been some inconsistent opinions in the USD
developer community about whether "varying" interpolation
is equivalent to "corner" or "point" domains for meshes.
However, DCCs such as Unity and Houdini assume that the
number of entries for attributes with "varying" interpolation
is the same as the number of points, and this change allows
Blender to import such assets without error.

This change is also consistent with the following OpenSubdiv
documentation for vertex/varying interpolation:

https://graphics.pixar.com/opensubdiv/docs/subdivision_surfaces.html#vertex-and-varying-data

This addresses issue #93052. Now converting the USD "varying" interpolation type to the "point" domain type when importing USD attributes. There have been some inconsistent opinions in the USD developer community about whether "varying" interpolation is equivalent to "corner" or "point" domains for meshes. However, DCCs such as Unity and Houdini assume that the number of entries for attributes with "varying" interpolation is the same as the number of points, and this change allows Blender to import such assets without error. This change is also consistent with the following OpenSubdiv documentation for vertex/varying interpolation: https://graphics.pixar.com/opensubdiv/docs/subdivision_surfaces.html#vertex-and-varying-data
Michael Kowalski added this to the 4.1 milestone 2024-02-20 22:12:55 +01:00
Michael Kowalski added the
Interest
USD
Interest
Pipeline, Assets & IO
labels 2024-02-20 22:12:55 +01:00
Michael Kowalski added 1 commit 2024-02-20 22:13:06 +01:00
This addresses issue #93052.

Now converting the USD "varying" interpolation type to
the "point" domain type when importing USD attributes.

There have been some inconsistent opinions in the USD
developer community about whether "varying" interpolation
is equivalent to "corner" or "point" domains for meshes.
However, DCCs such as Unity and Houdini assume that the
number of entries for attributes with "varying" interpolation
is the same as the number of points, and this change allows
Blender to import such assets without error.
Michael Kowalski requested review from Jesse Yurkovich 2024-02-20 22:13:46 +01:00
Michael Kowalski added this to the USD project 2024-02-20 22:13:58 +01:00
Jesse Yurkovich approved these changes 2024-02-21 04:25:26 +01:00
Jesse Yurkovich left a comment
Member

Looks ok and runs fine for the files I have locally and the file mentioned in the bug. I could also find no definitive documentation either way about if there should be a difference between varying and vertex in this context.

Looks ok and runs fine for the files I have locally and the file mentioned in the bug. I could also find no definitive documentation either way about if there should be a difference between `varying` and `vertex` in this context.
Bastien Montagne approved these changes 2024-02-21 16:01:08 +01:00
Bastien Montagne left a comment
Owner

Change looks reasonable and safe enough for 4.1.

Change looks reasonable and safe enough for 4.1.
Michael Kowalski merged commit 1d0bbefbb7 into blender-v4.1-release 2024-02-21 16:07:27 +01:00
Michael Kowalski deleted branch usd-varying-interpolation-import-fix 2024-02-21 16:07:29 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118539
No description provided.