Fix #118524: Loopcut crashes when not near an edge #118549

Philipp Oeser · 2024-02-21T10:04:15+01:00

Philipp Oeser commented

2024-02-21 10:04:15 +01:00

Caused by 1c0f374ec3

When EDBM_edge_find_nearest_ex does not find a nearest edge in
loopcut_mouse_move, then loopcut_update_edge will set
RingSelOpData ob to nullptr (rightfully so).

This would then crash in ringsel_draw (because we are trying to call
object_to_world() on the nullptr).

Prior to 1c0f374ec3 this was also "wrong", but
EDBM_preselect_edgering_draw would early out before using garbage
data.

Now guard against this and dont call EDBM_preselect_edgering_draw at
all if we dont have valid input.

Caused by 1c0f374ec3 When `EDBM_edge_find_nearest_ex` does not find a nearest edge in `loopcut_mouse_move`, then `loopcut_update_edge` will set `RingSelOpData` `ob` to nullptr (rightfully so). This would then crash in `ringsel_draw` (because we are trying to call `object_to_world()` on the nullptr). Prior to 1c0f374ec3 this was also "wrong", but `EDBM_preselect_edgering_draw` would early out before using garbage data. Now guard against this and dont call `EDBM_preselect_edgering_draw` at all if we dont have valid input.

Philipp Oeser added 1 commit 2024-02-21 10:04:25 +01:00

99232785bc Fix #118524 : Loopcut crashes when not near an edge

Caused by 1c0f374ec3

When `EDBM_edge_find_nearest_ex` does not find a nearest edge in
`loopcut_mouse_move`, then  `loopcut_update_edge` will set
`RingSelOpData` `ob` to nullptr (rightfully so).

This would then crash in `ringsel_draw` (because we are trying to call
`object_to_world()` on the nullptr.

Prior to 1c0f374ec3 this was also "wrong", but
`EDBM_preselect_edgering_draw` would early out before using garbage
data.

Now guard against this and dont call `EDBM_preselect_edgering_draw` at
all if we dont have valid input.

Philipp Oeser requested review from Hans Goudey 2024-02-21 10:04:39 +01:00

Philipp Oeser added this to the Modeling project 2024-02-21 10:04:47 +01:00

Philipp Oeser requested review from Sergey Sharybin 2024-02-21 10:05:55 +01:00

Sergey Sharybin approved these changes 2024-02-21 12:07:43 +01:00

Sergey Sharybin left a comment

For the reference, prior to the commit which actually revealed the crash ASAN was reporting

/Users/sergey/Developer/bf/blender/source/blender/editors/mesh/editmesh_loopcut.cc:91:63: runtime error: member access within null pointer of type 'Object'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/sergey/Developer/bf/blender/source/blender/editors/mesh/editmesh_loopcut.cc:91:63 in

For the reference, prior to the commit which actually revealed the crash ASAN was reporting ``` /Users/sergey/Developer/bf/blender/source/blender/editors/mesh/editmesh_loopcut.cc:91:63: runtime error: member access within null pointer of type 'Object' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/sergey/Developer/bf/blender/source/blender/editors/mesh/editmesh_loopcut.cc:91:63 in ```

Philipp Oeser merged commit 11db0b9dad into main

2024-02-21 12:38:16 +01:00

Philipp Oeser deleted branch 118524

2024-02-21 12:38:18 +01:00

Philipp Oeser referenced this issue from a commit

2024-02-21 12:38:20 +01:00

Fix #118524: Loopcut crashes when not near an edge

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #118524: Loopcut crashes when not near an edge #118549