Fix #118524: Loopcut crashes when not near an edge #118549

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:118524 into main 2024-02-21 12:38:16 +01:00
Member

Caused by 1c0f374ec3

When EDBM_edge_find_nearest_ex does not find a nearest edge in
loopcut_mouse_move, then loopcut_update_edge will set
RingSelOpData ob to nullptr (rightfully so).

This would then crash in ringsel_draw (because we are trying to call
object_to_world() on the nullptr).

Prior to 1c0f374ec3 this was also "wrong", but
EDBM_preselect_edgering_draw would early out before using garbage
data.

Now guard against this and dont call EDBM_preselect_edgering_draw at
all if we dont have valid input.

Caused by 1c0f374ec3 When `EDBM_edge_find_nearest_ex` does not find a nearest edge in `loopcut_mouse_move`, then `loopcut_update_edge` will set `RingSelOpData` `ob` to nullptr (rightfully so). This would then crash in `ringsel_draw` (because we are trying to call `object_to_world()` on the nullptr). Prior to 1c0f374ec3 this was also "wrong", but `EDBM_preselect_edgering_draw` would early out before using garbage data. Now guard against this and dont call `EDBM_preselect_edgering_draw` at all if we dont have valid input.
Philipp Oeser added 1 commit 2024-02-21 10:04:25 +01:00
Caused by 1c0f374ec3

When `EDBM_edge_find_nearest_ex` does not find a nearest edge in
`loopcut_mouse_move`, then  `loopcut_update_edge` will set
`RingSelOpData` `ob` to nullptr (rightfully so).

This would then crash in `ringsel_draw` (because we are trying to call
`object_to_world()` on the nullptr.

Prior to 1c0f374ec3 this was also "wrong", but
`EDBM_preselect_edgering_draw` would early out before using garbage
data.

Now guard against this and dont call `EDBM_preselect_edgering_draw` at
all if we dont have valid input.
Philipp Oeser requested review from Hans Goudey 2024-02-21 10:04:39 +01:00
Philipp Oeser added this to the Modeling project 2024-02-21 10:04:47 +01:00
Philipp Oeser requested review from Sergey Sharybin 2024-02-21 10:05:55 +01:00
Sergey Sharybin approved these changes 2024-02-21 12:07:43 +01:00
Sergey Sharybin left a comment
Owner

For the reference, prior to the commit which actually revealed the crash ASAN was reporting

/Users/sergey/Developer/bf/blender/source/blender/editors/mesh/editmesh_loopcut.cc:91:63: runtime error: member access within null pointer of type 'Object'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/sergey/Developer/bf/blender/source/blender/editors/mesh/editmesh_loopcut.cc:91:63 in
For the reference, prior to the commit which actually revealed the crash ASAN was reporting ``` /Users/sergey/Developer/bf/blender/source/blender/editors/mesh/editmesh_loopcut.cc:91:63: runtime error: member access within null pointer of type 'Object' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/sergey/Developer/bf/blender/source/blender/editors/mesh/editmesh_loopcut.cc:91:63 in ```
Philipp Oeser merged commit 11db0b9dad into main 2024-02-21 12:38:16 +01:00
Philipp Oeser deleted branch 118524 2024-02-21 12:38:18 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118549
No description provided.