Fix #118643: Translation of enum button tooltip not working in cases #118653

Philipp Oeser · 2024-02-23T11:21:38+01:00

Philipp Oeser commented

2024-02-23 11:21:38 +01:00

Originally caused by 90c4e2e6ec [which did not translate the tooltip
descriptions for enum items at all]
That was fixed in cbc5d861db [which was working fine for the default
translation context -- which is most of the time]

Now 7d7318f6c5 added the BLT_I18NCONTEXT_ID_ID translation context
to buttons_context_items (rightfully so) but using this context on the
enum item description translation does not really make sense. So as
a result, the description was not translated in this case.

To resolve, now dont use a special translation context for the
description of enum items at all, this is also what
property_enum_translate does.

Originally caused by 90c4e2e6ec [which did not translate the tooltip descriptions for enum items at all] That was fixed in cbc5d861db [which was working fine for the default translation context -- which is most of the time] Now 7d7318f6c59c added the `BLT_I18NCONTEXT_ID_ID` translation context to `buttons_context_items` (rightfully so) but using this context on the enum item **description** translation does not really make sense. So as a result, the description was not translated in this case. To resolve, now dont use a special translation context for the **description** of enum items at all, this is also what `property_enum_translate` does.

Philipp Oeser added 1 commit 2024-02-23 11:21:38 +01:00

e4ecc424ba Fix #118643 : Translation of enum button tooltip not working in cases

Originally caused by 90c4e2e6ec [which did not translate the tooltip
descriptions for enum items at all]
That was fixed in cbc5d861db [which was working fine for the default
translation context -- which is most of the time]

Now 7d7318f6c5 added the `BLT_I18NCONTEXT_ID_ID` translation context
to `buttons_context_items` (rightfully so) but using this context on the
enum item **description** translation does not really make sense. So as
a result, the description was not translated in this case.

To resolve, now dont use a special translation context for the
**description** of enum items at all, this is also what
`property_enum_translate` does.

Philipp Oeser added this to the User Interface project 2024-02-23 11:21:54 +01:00

Philipp Oeser requested review from Bastien Montagne 2024-02-23 11:22:00 +01:00

Philipp Oeser requested review from Hans Goudey 2024-02-23 11:22:06 +01:00

Philipp Oeser referenced this pull request

2024-02-23 11:22:34 +01:00

Regression: Tooltip translation in properties tab is affected #118643

Bastien Montagne approved these changes 2024-02-23 11:28:47 +01:00

Bastien Montagne left a comment

indeed, description (tooltip) should never use translation contexts.

Philipp Oeser referenced this issue from a commit

2024-02-23 11:55:49 +01:00

Fix #118643: Translation of enum button tooltip not working in cases