Fix #102860: crash importing a certain dae (collada) file #118751

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:102860 into blender-v4.1-release 2024-03-01 16:31:43 +01:00
Member

There seems to not be a strict rule to only have armatures as parents to
single bones, apparently collada files can also be set up to have mesh
parents for bones. As a consequence, the collada importer
joint_parent_map is not safe to fetch objects from and assume their
data can be cast to bArmature.

Ultimately, the joint_parent_map needs to be looked at again, this
patch just avoids a crash in this scenario (so no such joints will be
iported). Still better than crashing I guess.

There seems to not be a strict rule to only have armatures as parents to single bones, apparently collada files can also be set up to have mesh parents for bones. As a consequence, the collada importer `joint_parent_map` is not safe to fetch objects from and assume their data can be cast to `bArmature`. Ultimately, the `joint_parent_map` needs to be looked at again, this patch just avoids a crash in this scenario (so no such joints will be iported). Still better than crashing I guess.
Philipp Oeser added 1 commit 2024-02-26 15:28:21 +01:00
There seems to not be a strict rule to only have armatures as parents to
single bones, apparently collada files can also be set up to have mesh
parents for bones. As a consequence, the collada importer
`joint_parent_map` is not safe to fetch objects from and assume their
data can be cast to `bArmature`.

Ultimately, the `joint_parent_map` needs to be looked at again, this
patch just avoids a crash in this scenario (so no such joints will be
iported). Still better than crashing I guess.
Philipp Oeser added this to the Pipeline, Assets & IO project 2024-02-26 15:28:49 +01:00
Philipp Oeser added the
Interest
Collada
label 2024-02-26 15:28:55 +01:00
Philipp Oeser requested review from Gaia Clary 2024-02-26 15:29:04 +01:00
Philipp Oeser requested review from Sybren A. Stüvel 2024-02-26 15:29:10 +01:00
Philipp Oeser added the
Interest
Animation & Rigging
label 2024-02-26 15:29:17 +01:00
Sybren A. Stüvel approved these changes 2024-03-01 15:25:42 +01:00
Sybren A. Stüvel left a comment
Member

Thanks Philipp! I think this is fine, especially with the comment like that.

Thanks Philipp! I think this is fine, especially with the comment like that.
Philipp Oeser merged commit f880cbce93 into blender-v4.1-release 2024-03-01 16:31:43 +01:00
Philipp Oeser deleted branch 102860 2024-03-01 16:31:46 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118751
No description provided.