Sculpt: Add Lasso Hide tool #119140
No reviewers
Julien Kaspar
Hans Goudey
Daniel Bystedt
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#119140
Loading…
Reference in New Issue
No description provided.
Delete Branch "Sean-Kim/blender:80390-lasso-gesture-hide"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This commit adds the
SCULPT_OT_hide_show_lasso_gestureand thecorresponding Lasso Hide tool.
as a option in the header
sculpt_gesture.ccfor handling lassoselections with the
Outsideselection typeFor
SelectionType::Outside, the current implementation opts to notdo any filtering on the PBVH node level due to cases where the node
is mostly covered by a single gesture.
Addresses one of the tools in #80390
@blender-bot package
Package build started. Download here when ready.
@ -355,0 +355,4 @@/* Certain degenerate cases of a lasso shape can cause the resulting* frustum planes to enclose a node's AABB, therefore we must submit it* to be more throughly evaluated. */if (gesture_data->shape_type == ShapeType::Lasso) {I'd have to test to check the numbers, but my guess is that this
BKE_pbvh_node_frustum_exclude_AABBcheck is an important part of making the tool feel snappy when hiding a small portion of a large mesh. So maybe this fix can be considered separately, because the tradeoff isn't obvious to me.I get the concern - but this particular code path would be handling the opposite use-case if lassoing a small portion of a large mesh - most pbvh nodes would pass the
BKE_pbvh_node_frustum_exclude_AABBcheck. The situation you're describing should still be performant with these changes as that would go through theSelectionType::Insidecheck above.If you think the
SelectionType::Outsidefeature itself needs a bit more iteration though, I think it could be worked on separately.A possible way to achieve this could be to extend the
GestureDatastruct to contain a list of "included" and "excluded" nodes so that large batch operations for hide could be done through methods likepartialvis_all_update_meshwhich take advantage of threadingI just checked the tool on a mesh with 3.5 million vertices using a multires modifier. I think it works perfectly fine and I don't see any issues in terms of snappyness.
From me it is thumbs up for this commit
@ -398,2 +404,3 @@return lasso->mask_px[scr_co_s[1] * lasso->width + scr_co_s[0]].test();const bool bitmap_result = lasso->mask_px[scr_co_s[1] * lasso->width + scr_co_s[0]].test();return (bitmap_result && gesture_data->selection_type == SelectionType::Inside) ||Could this become a switch on the
selection_type?This PR works perfectly as intended when I've been testing it. Well done Sean kim! Approving now.
Hi @Sean-Kim I tested the tool a little bit, great functionality... 👍 and while testing, I noticed two things missing in comparison to the Box Hide tool...
The first thing is the ability to press and hold the Spacebar to move the entire selection region, like:
Lasso Mask example:
The second thing is the ability to click on an empty space to unhide everything, like:
Those are the two essential things missing in the Lasso Hide tool that are present in the Box Hide tool... I hope it can be addressed... 🙂
Other than that, it seems to work great...
Cheers...
@DanielBystedt - Thanks for the performance testing!
@TheRedWaxPolice - Thanks for the feedback and testing, I'll look into both of those this coming week.
Sculpt: Add Lasso Hide toolto WIP: Sculpt: Add Lasso Hide toolMarked as WIP for now until I address the two usecases pointed out above.
WIP: Sculpt: Add Lasso Hide toolto Sculpt: Add Lasso Hide toolAddressed feedback & updated the main post with a new GIF of the two features that were missing and pointed out by @TheRedWaxPolice
@blender-bot build
greetings!
whats preventing this from landing?