Fix #119427: UI: The Metadata is gone for the rendered image #119495

Closed

Philipp Oeser wants to merge 1 commits from lichtwerk/blender:119427 into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Philipp Oeser commented

2024-03-15 08:34:07 +01:00

Member

This got lost in d579ac2b3f

Without having called BKE_imbuf_stamp_info on the ImBuf there will be
no metadata to show. This is now done again at the end of
image_get_render_result

This got lost in d579ac2b3f80 Without having called `BKE_imbuf_stamp_info` on the ImBuf there will be no metadata to show. This is now done again at the end of `image_get_render_result`

Philipp Oeser added 1 commit 2024-03-15 08:34:16 +01:00

0c3718dc6e Fix #119427 : UI: The Metadata is gone for the rendered image

This got lost in d579ac2b3f

Without having called `BKE_imbuf_stamp_info` on the ImBuf there will be
no metadata to show. This is now done again at the end of
`image_get_render_result`

Philipp Oeser added this to the Render & Cycles project 2024-03-15 08:34:43 +01:00

Philipp Oeser added the

Images & Movies

Render Pipeline

labels 2024-03-15 08:35:04 +01:00

Philipp Oeser requested review from Sergey Sharybin 2024-03-15 08:35:10 +01:00

Sergey Sharybin commented

2024-03-15 10:20:45 +01:00

Owner

That is a good find! There are a couple of notes:

Maybe we should target the fix to 4.1?
The proposed code here follows the old behavior closer, but has some issues which seems to be easy to address. Description below.

One of the issue is that depending on how you access pass ImBuf you might or might not have metadata on it. For example, if you go via Render Result Image data-block, you'll have the metadata, but if you access render passes directly from RenderResult you would not get metadata.

Another issue (although, old code was probably the same) the metadata is re-created on the ImBuf on every redraw.

How about an alternative fix which ensures metadata on render passes ImBuf's at the end of the render? Attached the proposed fix.

That is a good find! There are a couple of notes: - Maybe we should target the fix to 4.1? - The proposed code here follows the old behavior closer, but has some issues which seems to be easy to address. Description below. One of the issue is that depending on how you access pass ImBuf you might or might not have metadata on it. For example, if you go via Render Result Image data-block, you'll have the metadata, but if you access render passes directly from RenderResult you would not get metadata. Another issue (although, old code was probably the same) the metadata is re-created on the ImBuf on every redraw. How about an alternative fix which ensures metadata on render passes ImBuf's at the end of the render? Attached the proposed fix.

fix_119427.patch

1.1 KiB

Sergey Sharybin requested review from Brecht Van Lommel 2024-03-15 10:20:54 +01:00

Philipp Oeser commented

2024-03-15 10:49:33 +01:00

Author

Member

Thx looking at it @Sergey !

I like your solution better as well, lets go with that one :)

Regarding targeting 4.1, I am all for it (if @ThomasDinges agrees).

In any case, would close this PR (since @Sergey 's solution is different enough to justify getting its own PR I think)

@Sergey : mind spitting that out as its own PR?

Thx looking at it @Sergey ! I like your solution better as well, lets go with that one :) Regarding targeting 4.1, I am all for it (if @ThomasDinges agrees). In any case, would close this PR (since @Sergey 's solution is different enough to justify getting its own PR I think) @Sergey : mind spitting that out as its own PR?

Philipp Oeser closed this pull request

2024-03-15 10:49:36 +01:00

Thomas Dinges commented

2024-03-15 11:00:48 +01:00

Owner

Fine with me for 4.1

Fine with me for 4.1

Philipp Oeser referenced this pull request

2024-03-15 14:32:50 +01:00

Fix #119427: UI: The Metadata is gone for the rendered image #119503

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119495

No description provided.