UI: Status Bar Keymap Spacing #120124

Harley Acheson · 2024-04-01T01:22:01+02:00

Harley Acheson commented

2024-04-01 01:22:01 +02:00

Adjustments to the spacing of keymap items shown in the status bar
while idle and during modal operators. Decreased space between icon
and related text makes each item have better separation.

While idle the Status Bar shows just mouse operations. Following shows four sets of these (Regular, Shift, Ctrl, Alt), the top of each showing how it looks currently, the bottom of each with this PR. You should notice a decrease in space between the icon and the related operation text:

While performing a modal operation, in this example a move by pressing "G". The top shows how it looks now, the bottom with this PR. There is a decrease in space between the icon and related text, but there still remains greater space to the next item. This helps them be visually grouped better while still using less horizontal space.

Adjustments to the spacing of keymap items shown in the status bar while idle and during modal operators. Decreased space between icon and related text makes each item have better separation. --- While idle the Status Bar shows just mouse operations. Following shows four sets of these (Regular, Shift, Ctrl, Alt), the top of each showing how it looks currently, the bottom of each with this PR. You should notice a decrease in space between the icon and the related operation text: ![image](/attachments/7f70f77f-3ba7-41dc-aae4-09a8ba8b1979) While performing a modal operation, in this example a move by pressing "G". The top shows how it looks now, the bottom with this PR. There is a decrease in space between the icon and related text, but there still remains greater space to the next item. This helps them be visually grouped better while still using less horizontal space. ![image](/attachments/babed78e-1d96-4da6-b8e3-fc461f765150)

image.png

18 KiB

image.png

26 KiB

image.png

26 KiB

image.png

61 KiB

👍 4

Harley Acheson added 1 commit 2024-04-01 01:22:07 +02:00

2b09181915 UI: Status Bar Keymap Spacing

Adjustments to the spacing of keymap items shown in the status bar
while idle and during modal operators. Decreased space between icon
and related text makes each item have better separation.

Harley Acheson added this to the User Interface project 2024-04-01 01:23:05 +02:00

Hadrien commented

2024-04-01 18:29:01 +02:00

First-time contributor

I think this works well with the "mouse" icons, but for the keycap (letter) icons, which fill the available width, the spacing appears just a bit cramped. Looking at before/after, I don't necessarily get the feeling that hotkeys "group" better with their respective names: to me it still reads as a continuous stream of text. I would suggest drawing a light backdrop behind each hotkey (provided this doesn't look too busy in practice). In this mockup I also added back 2 pixels between icon and text, as well as some more padding between hotkeys (eyeballed it, might be too much).

statusbar_backdrops.png

14 KiB

Harley Acheson commented

2024-04-01 20:18:10 +02:00

@HadrienBrissaud ...the keycap (letter) icons, which fill the available width, the spacing appears just a bit cramped...

Yes, those mouse icons are designed to hug the left side of their box. So I can compensate for that. The following shows the space between the icon and text being more consistent but still with greater space to the next item:

> @HadrienBrissaud ...the keycap (letter) icons, which fill the available width, the spacing appears just a bit cramped... Yes, those mouse icons are designed to hug the left side of their box. So I can compensate for that. The following shows the space between the icon and text being more consistent but still with greater space to the next item: ![image](/attachments/6b9aea93-73b9-49ae-9415-3d8333217522)

image.png

7.9 KiB

Harley Acheson added 2 commits 2024-04-01 20:19:46 +02:00

b07bd9cbba Merge branch 'main' of projects.blender.org:blender/blender into StatusBarSpacing

14e66c17fd Spacing adjustments

Hadrien commented

2024-04-01 20:34:00 +02:00

First-time contributor

This definitely feels cleaner. You had to make a special case for the mouse icons? I imagine they are left-aligned in the first place so they can be swapped for those with the click motion lines and not appear to move?

Harley Acheson requested review from Pablo Vazquez 2024-04-02 18:16:38 +02:00

Pablo Vazquez approved these changes 2024-04-02 18:22:27 +02:00

Pablo Vazquez left a comment

Yay for compact layouts!
This area seriously needs some love but for the time being this is great. Thanks!

Yay for compact layouts! This area seriously needs some love but for the time being this is great. Thanks!

Harley Acheson commented

2024-04-02 18:35:03 +02:00

This area seriously needs some love...

I've another PR that fills all the holes we have for the "event icons": #120117

And I have another experiment that greatly reduces the width of these by collapsing repeated "X X Axis, Y Y Axis": #120148

> This area seriously needs some love... I've another PR that fills all the holes we have for the "event icons": https://projects.blender.org/blender/blender/pulls/120117 And I have another experiment that greatly reduces the width of these by collapsing repeated "X X Axis, Y Y Axis": https://projects.blender.org/blender/blender/pulls/120148

Harley Acheson added 2 commits 2024-04-02 21:03:26 +02:00

3fba4abea8 Merge branch 'main' of projects.blender.org:blender/blender into StatusBarSpacing

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

6934d1f172 Comment changes

Harley Acheson commented

2024-04-02 21:05:44 +02:00

@blender-bot build