Brush Assets: Make enabled catalog storage in preferences optional #120264

Julian Eisel · 2024-04-04T18:58:53+02:00

Julian Eisel commented

2024-04-04 18:58:53 +02:00

Adds a new asset shelf option (STORE_ENABLED_CATALOGS_IN_PREFERENCES option in BPY) to use the Preferences for storing the enabled catalogs. This way asset shelf types can decide if for their use-case, they want to synchronize the enabled catalogs over Blender sessions and files, or keep the stored locally in the file.

This is important because for example on one hand, it would be annoying if for brush assets you'd have to enable the visible catalog tabs for every 3D View and every file, while on the other hand you need that level of control for the pose library where the catalogs the rigger/animator cares about varies from project to project, character to character and shot to shot.

Conceptually this also makes some sense: The new brush assets workflow synchronizes brush assets and their catalogs across Blender sessions and files, basically making them globally accessible independent of the current file/project, so treating the enabled catalogs the same is consistent.

Adds a new asset shelf option (`STORE_ENABLED_CATALOGS_IN_PREFERENCES` option in BPY) to use the Preferences for storing the enabled catalogs. This way asset shelf types can decide if for their use-case, they want to synchronize the enabled catalogs over Blender sessions and files, or keep the stored locally in the file. This is important because for example on one hand, it would be annoying if for brush assets you'd have to enable the visible catalog tabs for every 3D View and every file, while on the other hand you need that level of control for the pose library where the catalogs the rigger/animator cares about varies from project to project, character to character and shot to shot. Conceptually this also makes some sense: The new brush assets workflow synchronizes brush assets and their catalogs across Blender sessions and files, basically making them globally accessible independent of the current file/project, so treating the enabled catalogs the same is consistent.

Julian Eisel added 1 commit 2024-04-04 18:59:04 +02:00

aa2f606490 WIP: Make enabled catalog storage in preferences optional

Julian Eisel added 1 commit 2024-04-04 19:24:06 +02:00

b295fe35dc Get the option to work

Julian Eisel added 1 commit 2024-04-10 17:16:09 +02:00

007316c6bb Merge branch 'brush-assets-project' into temp-asset-shelf-enabled-catalogs-prefs

Julian Eisel added 1 commit 2024-04-11 16:45:04 +02:00

99cdff6f1b Refactor: Remove some unnecessary abstraction

Julian Eisel added 1 commit 2024-04-11 17:11:10 +02:00

223013f24e Add description for enumerator

Julian Eisel changed title from ~~WIP: Make enabled catalog storage in preferences optional~~ to Brush Assets: Make enabled catalog storage in preferences optional

2024-04-11 17:12:26 +02:00

Julian Eisel requested review from Brecht Van Lommel 2024-04-17 18:10:11 +02:00

Julian Eisel requested review from Hans Goudey 2024-04-17 18:10:38 +02:00

~~Julian Eisel referenced this pull request 2024-04-17 18:19:15 +02:00~~

Brush Assets Tasks #116337

Hans Goudey reviewed 2024-04-17 18:25:07 +02:00

Hans Goudey left a comment

Seems pretty straightforward. It would be nice to commit this (except for the BrushAssetShelf part) to main already though.

Seems pretty straightforward. It would be nice to commit this (except for the `BrushAssetShelf` part) to main already though.

source/blender/makesrna/intern/rna_ui.cc Outdated

						
				@ -2312,0 +2313,4 @@

				       "STORE_ENABLED_CATALOGS_IN_PREFERENCES",

				       0,

				       "Store Enabled Catalogs in Preferences",

				       "Use the Preferences to store the enabled catalogs of this asset shelf, rather than "