Fix: renaming an ID does not properly update actions in the NLA #120292

Philipp Oeser · 2024-04-05T11:38:34+02:00

Philipp Oeser commented

2024-04-05 11:38:34 +02:00

BKE_animdata_fix_paths_rename would tag the owner ID itself
(ID_RECALC_SYNC_TO_EVAL) upon renaming when a corresponding fcurve was
found/fixed, however the action itself wasnt tagged. "The action is an
own datablock, meaning, changes to f-curves need to copy those changes
to all evaluated versions of the action datablock" (wording from
4045730d58).

(this is also the reason the action would "fix" itself after entering
tweakmode on it in the NLA, since that ripples down to
ANIM_list_elem_update -- which does the tagging on the action then).

Part of #104055

`BKE_animdata_fix_paths_rename` would tag the owner ID itself (`ID_RECALC_SYNC_TO_EVAL`) upon renaming when a corresponding fcurve was found/fixed, however the action itself wasnt tagged. "The action is an own datablock, meaning, changes to f-curves need to copy those changes to all evaluated versions of the action datablock" (wording from 4045730d58da). (this is also the reason the action would "fix" itself after entering tweakmode on it in the NLA, since that ripples down to `ANIM_list_elem_update` -- which does the tagging on the action then). Part of #104055

Philipp Oeser added 1 commit 2024-04-05 11:38:45 +02:00

e8ec17ed6a Fix: renaming an ID does not properly update actions in the NLA

`BKE_animdata_fix_paths_rename` would tag the owner ID itself
(`ID_RECALC_SYNC_TO_EVAL`) upon renaming when a corresponding fcurve was
found/fixed, however the action itself wasnt tagged. "The action is an
own datablock, meaning, changes to f-curves need to copy those changes
to all evaluated versions of the action datablock" (wording from
4045730d58).

(this is also the reason the action would "fix" itself after entering
tweakmode on it in the NLA, since that ripples down to
`ANIM_list_elem_update` -- which does the tagging on the action then).

Part of #104055

Philipp Oeser added this to the Animation & Rigging project 2024-04-05 11:39:02 +02:00

Philipp Oeser requested review from Sybren A. Stüvel 2024-04-05 11:39:08 +02:00

Philipp Oeser requested review from Sergey Sharybin 2024-04-05 11:39:14 +02:00

Philipp Oeser added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix: renaming an ID does not properly update actions in the NLA #120292