Fix #120721: Collada: Import with loose edges not immediately show them #120737

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:120721 into main 2024-04-17 14:21:20 +02:00
Member

Exposed by 1ea169d90e

Colladas MeshImporter::mesh_add_edges is a copy from mesh_add_edges
in source/blender/editors/mesh/mesh_data.cc (done in 2c05190374 --
there is a comment to deduplicate this into BKE, but this wont be done
in this patch).

However, as time passed there have been additions to the later, namely:

  • 353fe610ed (clearing the mesh runtime caches)
  • 12becbf0df (altering selection handling, guess this can be ignored
    here since collada generally does not seem to select geometry)

So in order to resolve, now also clear the caches for collada as in
353fe610ed (even though just the subset of just `mesh->runtime-

loose_edges_cache.tag_dirty()` would also be enough).

Exposed by 1ea169d90e Colladas `MeshImporter::mesh_add_edges` is a copy from `mesh_add_edges` in `source/blender/editors/mesh/mesh_data.cc` (done in 2c0519037467 -- there is a comment to deduplicate this into BKE, but this wont be done in this patch). However, as time passed there have been additions to the later, namely: - 353fe610ed2d (clearing the mesh runtime caches) - 12becbf0dffe (altering selection handling, guess this can be ignored here since collada generally does not seem to select geometry) So in order to resolve, now also clear the caches for collada as in 353fe610ed2d (even though just the subset of just `mesh->runtime- >loose_edges_cache.tag_dirty()` would also be enough).
Philipp Oeser added 1 commit 2024-04-17 11:41:50 +02:00
Exposed by 1ea169d90e

Colladas `MeshImporter::mesh_add_edges` is a copy from `mesh_add_edges`
in `source/blender/editors/mesh/mesh_data.cc` (done in 2c05190374 --
there is a comment to deduplicate this into BKE, but this wont be done
in this patch).

However, as time passed there have been additions to the later, namely:

- 353fe610ed (clearing the mesh runtime caches)
- 12becbf0df (altering selection handling, guess this can be ignored
here since collada generally does not seem to select geometry)

So in order to resolve, now also clear the caches for collada as in
353fe610ed (even though just the subset of just `mesh->runtime-
>loose_edges_cache.tag_dirty()` would also be enough).
Philipp Oeser requested review from Hans Goudey 2024-04-17 11:42:03 +02:00
Philipp Oeser added this to the Modeling project 2024-04-17 11:42:08 +02:00
Hans Goudey approved these changes 2024-04-17 14:13:39 +02:00
Hans Goudey left a comment
Member

Looks good to me, thanks.

Looks good to me, thanks.
Philipp Oeser merged commit 0bda626ba3 into main 2024-04-17 14:21:20 +02:00
Philipp Oeser deleted branch 120721 2024-04-17 14:21:22 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120737
No description provided.