Fix #115460: EEVEE-Next: Missing bind when drawing curves #121064

Jeroen Bakker · 2024-04-25T09:09:39+02:00

Jeroen Bakker commented

2024-04-25 09:09:39 +02:00

When drawing hair/curves the material shader has a "a" texture slot,
but this slot was never bound to a texture. This PR fixes this by
adding a default texture to it and when available tries to bind
CD_AUTO_FROM_NAME resources.

This part seems to be not implemented when the new curve rendering
was added. CD_AUTO_FROM_NAME was never considered and therefore the
layer could not be found, and the sampler could not be found.

On the other hand Curves.active_uvmap is not filled which might or
might not be an issue on data management level and complicated this
fix.

Fixes #115460

When drawing hair/curves the material shader has a "a" texture slot, but this slot was never bound to a texture. This PR fixes this by adding a default texture to it and when available tries to bind CD_AUTO_FROM_NAME resources. This part seems to be not implemented when the new curve rendering was added. `CD_AUTO_FROM_NAME` was never considered and therefore the layer could not be found, and the sampler could not be found. On the other hand `Curves.active_uvmap` is not filled which might or might not be an issue on data management level and complicated this fix. Fixes #115460

Jeroen Bakker added this to the 4.2 LTS milestone 2024-04-25 09:09:39 +02:00

Jeroen Bakker added the

Module

EEVEE & Viewport

label 2024-04-25 09:09:39 +02:00

Jeroen Bakker self-assigned this 2024-04-25 09:09:40 +02:00

Jeroen Bakker added 1 commit 2024-04-25 09:09:47 +02:00

8249711ee1 EEVEE-Next: Fix missing texture bind when drawing curves/hair

When drawing hair/curves the material shader has a "a" texture slot,
but this slot was never bound to a texture. This PR fixes this by
default add a dummy texture to it.

Jeroen Bakker added this to the EEVEE & Viewport project 2024-04-25 09:09:52 +02:00

Jeroen Bakker requested review from Clément Foucault 2024-04-25 09:10:05 +02:00

Jeroen Bakker referenced this pull request

2024-04-25 09:40:28 +02:00

EEVEE: shader UV map input is broken for hair curves #115460

Jeroen Bakker changed title from ~~EEVEE-Next: Fix missing texture bind when drawing curves/hair~~ to WIP: EEVEE-Next: Fix missing texture bind when drawing curves/hair

2024-04-25 10:02:42 +02:00

Jeroen Bakker commented

2024-04-25 10:03:01 +02:00

Moving to WIP, as it might hide other issues as well.

Jeroen Bakker changed title from ~~WIP: EEVEE-Next: Fix missing texture bind when drawing curves/hair~~ to EEVEE-Next: Fix missing texture bind when drawing curves/hair

2024-04-25 12:03:08 +02:00

Jeroen Bakker added 1 commit 2024-04-25 12:03:16 +02:00

6f594db22a EEVEE-Next: Fix auto uvmap attribute binding for curves

Jeroen Bakker changed title from ~~EEVEE-Next: Fix missing texture bind when drawing curves/hair~~ to Fix #115460: EEVEE-Next: Missing texture bind when drawing curves

2024-04-25 12:03:46 +02:00

Jeroen Bakker changed title from ~~Fix #115460: EEVEE-Next: Missing texture bind when drawing curves~~ to Fix #115460: EEVEE-Next: Missing bind when drawing curves

2024-04-25 12:07:29 +02:00

Clément Foucault commented

2024-04-25 12:41:41 +02:00

@HooglyBoogly do you have any input on this?

Hans Goudey reviewed 2024-04-26 18:32:17 +02:00

Hans Goudey left a comment

To be honest I don't really understand the context or the need for separate "input name" and "attribute name" variables, or why the API is set up in a way that requires us to store both of them. My instinct is that it's more complicated than it needs to be, but yeah, I'm definitely missing something.

Jeroen Bakker commented

2024-04-26 23:02:19 +02:00

Gpu materials can be shared between multiple objects. Curves but also other geometry. Each object can have an active uvmap that is differently named.

We don’t want to recompile the shaders based on the geometry. So this pr introduces a mapping system.

This is specific for hair as mapping attributes for meshes is part of the vbo api (aliasing).

For hair we have a refine shader that can create texture buffers. We also don’t want to generate too much texture buffers when the active uvmap is also accessed by name in the same shader.

I am open for other solutions as well. I do thing when the curves.active_uvmap is available we can reduce some lookups during this process. But I am not sure if that attribute should be used in this case….

Gpu materials can be shared between multiple objects. Curves but also other geometry. Each object can have an active uvmap that is differently named. We don’t want to recompile the shaders based on the geometry. So this pr introduces a mapping system. This is specific for hair as mapping attributes for meshes is part of the vbo api (aliasing). For hair we have a refine shader that can create texture buffers. We also don’t want to generate too much texture buffers when the active uvmap is also accessed by name in the same shader. I am open for other solutions as well. I do thing when the curves.active_uvmap is available we can reduce some lookups during this process. But I am not sure if that attribute should be used in this case….

Merge conflict checking is in progress. Try again in few moments.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u eevee/fix/missing-curve-texture-bind:Jeroen-Bakker-eevee/fix/missing-curve-texture-bind

git checkout Jeroen-Bakker-eevee/fix/missing-curve-texture-bind

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #115460: EEVEE-Next: Missing bind when drawing curves #121064

Checkout