Fix: make auto-keying reliably key all needed bone channels #124054

Nathan Vegdahl · 2024-07-02T17:22:32+02:00

Nathan Vegdahl commented

2024-07-02 17:22:32 +02:00

This is a follow-up to #123998 which fixed autokeying on objects when
the "Only Insert Needed" user preference was enabled. This fixes an
essentially identical bug for auto-keying bones, but also fixes a
different-but-related bug unique to bone keying.

In the first bug the location channel would erroneously not get keyed
sometimes when the "Only Insert Needed" user preference was enabled.
This fixes that by passing in whether more than one bone is being keyed
or not, and using that to accurately determine if location actually
needs to be keyed.

In the second bug, the location channel would erroneously not get keyed
when "Auto IK" was used to transform bones. This fixes that by just
being over-conservative. This unforunately leads to more bones getting
their location channel keyed than needed when Auto IK is used, but this
is better than failing to key needed channels, which was the previous
behavior. I left a comment explaining the situation, along with a TODO
to address this in a more satisfying way in the future.

This is a follow-up to #123998 which fixed autokeying on objects when the "Only Insert Needed" user preference was enabled. This fixes an essentially identical bug for auto-keying bones, but *also* fixes a different-but-related bug unique to bone keying. In the first bug the location channel would erroneously not get keyed sometimes when the "Only Insert Needed" user preference was enabled. This fixes that by passing in whether more than one bone is being keyed or not, and using that to accurately determine if location actually needs to be keyed. In the second bug, the location channel would erroneously not get keyed when "Auto IK" was used to transform bones. This fixes that by just being over-conservative. This unforunately leads to more bones getting their location channel keyed than needed when Auto IK is used, but this is better than *failing* to key needed channels, which was the previous behavior. I left a comment explaining the situation, along with a TODO to address this in a more satisfying way in the future.

Nathan Vegdahl added this to the 4.2 LTS milestone 2024-07-02 17:22:32 +02:00

Nathan Vegdahl added the

Module

Animation & Rigging

label 2024-07-02 17:22:32 +02:00

Nathan Vegdahl added 1 commit 2024-07-02 17:22:43 +02:00

Fix: make auto-keying reliably key all needed bone channels

buildbot/vexp-code-patch-lint Build done.

Details

buildbot/vexp-code-patch-linux-x86_64 Build done.

Details

buildbot/vexp-code-patch-darwin-x86_64 Build done.

Details

buildbot/vexp-code-patch-darwin-arm64 Build done.

Details

buildbot/vexp-code-patch-windows-amd64 Build done.

Details

buildbot/vexp-code-patch-coordinator Build done.

Details

5626bbb7d4

This is a follow-up to #123998 which fixed autokeying on objects when
the "Only Insert Needed" user preference was enabled. This fixes an
essentially identical bug for auto-keying bones, but *also* fixes a
different-but-related bug unique to bone keying.

In the first bug the location channel would erroneously not get keyed
sometimes when the "Only Insert Needed" user preference was enabled.
This fixes that by passing in whether more than one bone is being keyed
or not, and using that to accurately determine if location actually
needs to be keyed.

In the second bug, the location channel would erroneously not get keyed
when "Auto IK" was used to transform bones. This fixes that by just
being over-conservative. This unforunately leads to more bones getting
their location channel keyed than needed when Auto IK is used, but this
is better than *failing* to key needed channels, which was the previous
behavior. I left a comment explaining the situation, along with a TODO
to address this in a more satisfying way in the future.

Nathan Vegdahl requested review from Christoph Lendenfeld 2024-07-02 17:23:30 +02:00

Christoph Lendenfeld approved these changes 2024-07-04 09:36:46 +02:00

Christoph Lendenfeld left a comment

lgtm!
nice work fixing the auto-ik thing in one go :)

lgtm! nice work fixing the auto-ik thing in one go :)

Nathan Vegdahl commented

2024-07-04 09:44:32 +02:00

@blender-bot build

Nathan Vegdahl merged commit b31d34033a into blender-v4.2-release

2024-07-04 10:18:45 +02:00

Nathan Vegdahl referenced this issue from a commit

2024-07-04 10:18:45 +02:00