extensions/io_mesh_atomic
2
1
Fork 1
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Added XYZ animation frames #1

Open
John-Ferrier wants to merge 1 commits from John-Ferrier/io_mesh_atomic:main into main
pull from: John-Ferrier/io_mesh_atomic:main
merge into: extensions:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 1 Files Changed 3 +147 -115
John-Ferrier commented 2024-07-28 01:23:07 +02:00
First-time contributor
Copy Link

Added functionality for animations of XYZ files when importing with the option "Load all frames"

Added functionality for animations of XYZ files when importing with the option "Load all frames"
John-Ferrier added 1 commit 2024-07-28 01:23:08 +02:00 
Added functionality for animations of XYZ files when importing with the option "Load all frames"
Nika Kutsniashvili commented 2024-09-19 15:40:12 +02:00
Owner
Copy Link

Hey. I have commit rights to this and can help you merge this, but I'm not really qualified to make judgement on the changes here. Can you give me some example files I can test importing? And describe more of what changes, because I see lot of deleted code as well as new ones.

Hey. I have commit rights to this and can help you merge this, but I'm not really qualified to make judgement on the changes here. Can you give me some example files I can test importing? And describe more of what changes, because I see lot of deleted code as well as new ones.
John-Ferrier commented 2024-09-19 16:56:17 +02:00
Author
First-time contributor
Copy Link

Sure. It's been a while since that one. But, if I remember correctly, there was a section of the code dedicated to sequential loading of XYZ files for the sake of animation. Unfortunately, there was a mistake and it would only load one frame. So, I fixed the error to allow for loading all frames. You can check this by loading sequential XYZ files of the same molecule type.

I used the newer code to make an animation of vibrational modes of a molecule. :)

Sure. It's been a while since that one. But, if I remember correctly, there was a section of the code dedicated to sequential loading of XYZ files for the sake of animation. Unfortunately, there was a mistake and it would only load one frame. So, I fixed the error to allow for loading all frames. You can check this by loading sequential XYZ files of the same molecule type. I used the newer code to make an animation of vibrational modes of a molecule. :)
Nika Kutsniashvili commented 2024-09-20 15:41:17 +02:00
Owner
Copy Link

Do you have example files I can test with?

Do you have example files I can test with?
John-Ferrier commented 2024-09-20 19:26:16 +02:00
Author
First-time contributor
Copy Link

yes. it just might take about a week to get that to you. I'm currently in the throws of my PhD defense so I can't allocate too much time to this right now. But, I will be back. :)

yes. it just might take about a week to get that to you. I'm currently in the throws of my PhD defense so I can't allocate too much time to this right now. But, I will be back. :)
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:John-Ferrier-main
git checkout John-Ferrier-main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: extensions/io_mesh_atomic#1
No description provided.
Delete Branch "John-Ferrier/io_mesh_atomic:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?