Is there a reason this isn't closed yet? Is someone waiting on me to do something?
I made changes and tried to update this but can't:
/add_mesh_BoltFactory$ git push me swtya_CounterSinkHead
To projects.blender.org:sw-tya/add_mesh_BoltFactory.git
` !…
@sw-tya wrote:
4.2 is not any worse, that's still awaiting the directory search backport.
could you edit this comment to make it something like:
~~4.2 is not any worse, that's still…
@nickberckley wrote:
@linux_dr can you merge main in this PR branch?
I have no permissions to merge any PRs. If someone wants to grant me such permissions we can stop asking you.
Also…
I will review this when I can, but I still wanted to thank you for your contributions! 🎉
If you’re in a hurry, you could simply branch off swtya_combinedFixes_PR10_and_PR11
(git checkout swtya_combinedFixes_PR10_and_PR11 ;git checkout -b {new_branch_name_here}
), and cherry-pick…
Closed by mistake
I certainly applaud your research and initiative, but my concern is “the best thing about standards is there are so many to choose from.” Would there be a reason this couldn’t be an additional parameter in the GUI? I would love if the default value changed according to the shank diameter, but I expect other standards bodies will declare other counter sink angles in their own ecosystems.
The pull/12 should address …
Congrats on your second PR… I will look at it ASAP, but wanted to mention that typing #12 in a comment should generate a link to it
@nickberckley, this should be ready to rebase and merge after #10
@nickberckley, this should be ready to merge.
@sw-tya wrote:
…, that's still awaiting the directory search backport. 4.3 works correctly.
I don’t know anything about this directory search feature you mentioned. Can you please…
Yes, good catch. I hadn't realized that I had separated out the change from IntProperty
to FloatProperty
from the change of 10
to 12.5
in the presets, but I obviously had. I would not do a…
@sw-tya, thank you for your quick review