- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
For posterity: we talked in person, and it turns out we do not already have the adt at the call sites. There may still be refactors that could make this better, but we agreed that since this is…
I've added an assert, as well as explicitly documenting the relationship between curves and channel_bag in SeqAnimationBackup's declaration itself.
action_fcurve_remove() only works for slotted actions. But regardless, you're right that it's better to update that to work with legacy actions as well and then use it.
Yup. It was never actually being used.
I'm not super happy about the code duplication here, but it's not clear to me how to get rid of it. The usual pattern is to call the non-const overload of the function with the constness of the parameters casted away. That works for the action parameter, but I couldn't figure out a way to do that for the callback parameter.