Nathan Vegdahl nathanvegdahl
  • Amsterdam, Netherlands
  • https://cessen.com
  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Nathan Vegdahl pushed to main at nathanvegdahl/blender 2023-09-12 10:32:18 +02:00
aaddb25fa3 Cleanup: remove unneeded include
e656e850a6 Animation: Rename ACTION_OT_sample
9e5e04e915 Animation: Rename Graph_OT_sample
057c9364fc Cleanup: use braces around statements
f942f64b1d Cleanup: format
Compare 41 commits »
Nathan Vegdahl pushed to main at blender/blender 2023-09-12 10:31:56 +02:00
aaddb25fa3 Cleanup: remove unneeded include
Nathan Vegdahl pushed to main at blender/blender 2023-09-11 18:28:28 +02:00
d64e4a387a Fix #111780: bone collections and undo don't work together
Nathan Vegdahl closed issue blender/blender#111780 2023-09-11 18:28:27 +02:00
Bone collections and bone collection membership are not handled properly when undoing in armature edit mode
Nathan Vegdahl deleted branch 111780_armature_undo_with_collections from nathanvegdahl/blender 2023-09-11 18:28:26 +02:00
Nathan Vegdahl merged pull request blender/blender#111965 2023-09-11 18:28:25 +02:00
Fix #111780: bone collections and undo don't work together
57f9cdc96c Fix up the closing of namespaces
cbd1407dd2 Fix linking warning when building with clang
0fbc3621a7 Fix linking warning when building with clang
ce0df94a45 Fix linking warning when building with clang
Nathan Vegdahl commented on pull request blender/blender#111965 2023-09-11 17:32:57 +02:00
Fix #111780: bone collections and undo don't work together

I think it's fine to wrap these two function declarations in a #ifdef __cplusplus block.

Additionally had to move it out of the extern C block, which makes sense.

ffbf980f5c Address additional review comments.
2a53aa8f45 Address review comments.
3e11ea72e6 Clang format.
60cdc74158 Workaround for losing bone collection membership on some undo steps
0b8ebc1759 Don't blindly follow naming where it doesn't make sense
Compare 181 commits »
Nathan Vegdahl commented on pull request blender/blender#111965 2023-09-11 12:48:33 +02:00
Fix #111780: bone collections and undo don't work together

Apparently that doesn't work, because it's treated as a function prototype. The correct initialization is apparently just:

blender::Map<BoneCollection *, BoneCollection *> bcoll_map;

Whi…

Nathan Vegdahl commented on pull request blender/blender#111965 2023-09-11 12:33:21 +02:00
Fix #111780: bone collections and undo don't work together

Ah, that's my rusty (pun intended) C++ showing through. I forgot you could even initialize things that way in C++. Thanks!

Nathan Vegdahl commented on pull request blender/blender#111965 2023-09-11 12:10:42 +02:00
Fix #111780: bone collections and undo don't work together

Oops. Thanks for catching that!

Nathan Vegdahl commented on pull request blender/blender#111965 2023-09-11 12:09:51 +02:00
Fix #111780: bone collections and undo don't work together

Ah, very good point. Indeed, it's not obvious that the list won't always be empty. I'll add that in the comment.

Nathan Vegdahl pushed to main at nathanvegdahl/blender 2023-09-11 11:31:53 +02:00
8460aac59d I18n: translate drag and drop messages for sockets
fca8df9415 Fix #112087: Float curve flickers with aligned points at x axis
825cc14e74 Cleanup: Cycles: Remove unused argument
e20f86547a Cycles: Fix compilation of the shader table precomputing tool
48b8c8f78f Fix #112129: Remove Blank Items from "Region Toggle" Pie Menu
Compare 193 commits »
Nathan Vegdahl commented on issue blender/blender#112134 2023-09-11 11:24:11 +02:00
Animation: create a full separate copy of BoneCollections while in armature edit mode

That's a good question. And it does give me a bit of pause if this is actually what we want to proceed with, rather than e.g. waiting to just get rid of the edit mode data structures entirely. …

Nathan Vegdahl commented on pull request blender/blender#111965 2023-09-11 11:13:19 +02:00
Fix #111780: bone collections and undo don't work together

I think the main point of armature edit data is that it is not hierarchical, i.e. bone coordinates are stored relative to the armature rather than the parent bone, and thus bones can be easily…

Nathan Vegdahl commented on issue blender/blender#112018 2023-09-11 10:53:38 +02:00
AgX has banding-like issues on hyper saturated gradients

Yeah, I'm not totally sure what the right tag(s) are for this.

In this case, I am one of the devs. I've assigned to myself, since @Eary is no longer available.