- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
I think this is another case where we're going to want to take into account the handles. Because although the keys may be within a pixel, their handles can potentially extend high up or high down, making the curve between those two keys something we would want to make sure to draw.
Just a couple of comments that are now out of date (I think?) and can be removed at this point. Other than that, looks good to me!
This comment is also outdated, I think, and can just be removed.
This doc comment feels out of date to me now. And the name of the function is now pretty self-documenting.
Yeah, I was thinking of that and similar edge cases when I mentioned denormal numbers. But indeed, the bones involved would have to be extremely close to the origin (on the order of 1.0e-36 ish…
I've created a corresponding issue in the Blender repo to track the Blender-side investigation: blender/blender#111043
Confirmed that it still happens in latest main as well.
I can repro on 3.6. I'll test in latest main as well once my build finishes.
But the result is even odder than the report suggests, and I believe the report is at least partially mis-attributin…
Both names feel about equivalently clear to me: they both give an idea of what it is, but don't define it precisely. So I'm happy for it to be changed if you think it's better, but I don't have a…
Looks good to me, although I certainly have less understanding of overrides than you do. :-)
I think it could use a bit of testing to make sure it behaves the way people generally want. I'll…
Just some very minor nits in a couple comments. Other than that, looks good to me!