Nathan Vegdahl nathanvegdahl
  • Amsterdam, Netherlands
  • https://cessen.com
  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Nathan Vegdahl commented on pull request blender/blender#110764 2023-08-04 17:29:41 +02:00
Animation: Common curve drawing for FCurves

I played around with a build, and this computation of the evaluation_step doesn't seem to be right (it gives very inconsistent drawing resolutions, sometimes extremely low, sometimes very high).

Nathan Vegdahl commented on pull request blender/blender#110796 2023-08-04 16:06:36 +02:00
Fix #110169: nearly flat normalized fcurves jump around in editor

I wrote a new ulps-based function ulp_diff_ff() to implement this fix. I think this new function will generally be useful in resolving certain kinds of floating point issues in the future as…

Nathan Vegdahl created pull request blender/blender#110796 2023-08-04 15:59:41 +02:00
Fix #110169: nearly flat normalized fcurves jump around in editor
Nathan Vegdahl created branch fix_110169_broken_fcurve_normalization in nathanvegdahl/blender 2023-08-04 15:55:29 +02:00
d7f5974ad6 Fix #110169: nearly flat normalized fcurves jump around in editor
Nathan Vegdahl pushed to main at nathanvegdahl/blender 2023-08-04 13:51:35 +02:00
1f612605ab Fix #110732: blender_theme_as_c fails fails with error
1e1f4db8b6 Tools: add 'diff' and 'email' attrs to git_log utility module
ed6e24b176 Fix resource leak in git_log utility module
9ba38d5bb6 License checker: scan paths "*.inl;*.ch;*.osl;*.metal;*.tables"
0caf227530 License headers: use SPDX-FileCopyrightText for *.inl and *.osl files
Compare 339 commits »
Nathan Vegdahl commented on issue blender/blender#110169 2023-08-03 11:59:46 +02:00
Broken FCurve rendering

Point 1 appears to be a floating point precision issue. That particular curve is almost completely flat, but is off just enough for normalizing to try to expand it. However, due to how tiny…

Nathan Vegdahl commented on issue blender/blender#110169 2023-08-03 10:21:47 +02:00
Broken FCurve rendering

Indeed, #110301 resolves point 2 (curve drawing resolution). Before/after:

curve_resolution_before_after.png

However, it does not…

Nathan Vegdahl commented on issue blender/blender#110169 2023-08-03 10:04:46 +02:00
Broken FCurve rendering

Got it! Indeed, that appears to be a bug. Thank you for the report and the video!

Nathan Vegdahl commented on issue blender/blender#110169 2023-08-03 09:54:16 +02:00
Broken FCurve rendering

I believe the curve resolution issue (point 2 in the issue description above) will be addressed by #110301. In addition to improving performance, that PR also switches to computing curve…

Nathan Vegdahl approved blender/blender#110712 2023-08-02 11:40:56 +02:00
AgX-Step2: Use OCIO's built-in function for sRGB

Looks good to me!

Nathan Vegdahl created repository nathanvegdahl/animation-layers-prototype 2023-08-01 11:07:54 +02:00
Nathan Vegdahl commented on pull request blender/blender#110074 2023-08-01 10:59:14 +02:00
NLA: Swap strips fixes

Got it. Thanks for the explanation! I'll add this to the animation & rigging module meeting agenda (this Thursday), to see which solution people prefer.

Nathan Vegdahl commented on pull request blender/blender#110135 2023-08-01 10:03:40 +02:00
Drivers: implement fallback values for RNA path based variables.

I'm definitely liking this direction!

Nathan Vegdahl approved blender/blender#110605 2023-07-31 17:51:57 +02:00
Fix #110161: Crash on dragging a Speaker NLA strip

Looks good to me.

Nathan Vegdahl commented on pull request blender/blender#110567 2023-07-31 17:24:29 +02:00
Animation: Match Slope slider

I think we should bring up the name in the next Animation module meeting.

Good call. Added to the agenda.

Nathan Vegdahl commented on pull request blender/blender#110567 2023-07-31 17:13:05 +02:00
Animation: Match Slope slider

Ah, interesting. I interpreted it to mean "left/right-most key of the segment". Although that's probably because of the fcurve_segment_*_get names, in my case.

In any case, I think the…

Nathan Vegdahl commented on pull request blender/blender#109015 2023-07-31 17:06:24 +02:00
Animation: Move Snapping to Scene

Would it be worth taking the time to switch from r_val_final to just returning the value? (transform_snap_anim_flush_data() is also like this.) Maybe not—maybe better as a separate clean up PR.

Nathan Vegdahl suggested changes for blender/blender#109015 2023-07-31 17:06:24 +02:00
Animation: Move Snapping to Scene

Over all looks good to me! Mainly just some questions + nits.