Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl approved blender/blender#127911 2024-09-24 10:18:46 +02:00
Fix #127758: Resorting keys in the Graph Editor with multiple actions failed

Looks good, and indeed fixes the bug in testing. 👍

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-24 10:16:12 +02:00
328709eec4 Update reports/2024.md
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-24 10:11:16 +02:00
1576984845 Update reports/2024.md
Nathan Vegdahl approved blender/blender#128039 2024-09-24 10:09:09 +02:00
Anim: Replace BKE_fcurves_filter with new API

Looks good, and it survived some tire kicking.

Nathan Vegdahl deleted branch fcurve_listbase_loops from nathanvegdahl/blender 2024-09-24 10:00:16 +02:00
Nathan Vegdahl merged pull request blender/blender#127920 2024-09-24 10:00:12 +02:00
Anim: update some uses of listbases of fcurves
Nathan Vegdahl pushed to main at blender/blender 2024-09-24 10:00:11 +02:00
4bfa0de388 Anim: update some uses of listbases of fcurves
Nathan Vegdahl approved blender/blender#128036 2024-09-23 17:57:35 +02:00
Refactor: Anim: replace BKE_fcurve_find() calls with new API

Approved. Just take a look at blender/blender#128036 (comment) regarding moving the TODO to where my past blunder was.

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-23 17:55:01 +02:00
681290bcd7 Update reports/2024.md
Nathan Vegdahl commented on pull request blender/blender#128036 2024-09-23 17:54:09 +02:00
Refactor: Anim: replace BKE_fcurve_find() calls with new API

Agreed this is out of scope. I'll add it to my todo to look at later.

Nathan Vegdahl commented on pull request blender/blender#128036 2024-09-23 17:48:35 +02:00
Refactor: Anim: replace BKE_fcurve_find() calls with new API

If you don't feel like doing it as part of this PR, I think it suffices to just move the TODO to that if clause. Particularly since we'll be getting rid of the legacy action stuff before it…

Nathan Vegdahl commented on pull request blender/blender#128036 2024-09-23 17:46:58 +02:00
Refactor: Anim: replace BKE_fcurve_find() calls with new API

Oooh, good point.

But I think that means the if clause for the layered action case is wrong, then (again, thanks to past me). Instead of just `if (USER_EXPERIMENTAL_TEST(&U, use_animation_bakla…

Nathan Vegdahl suggested changes for blender/blender#128036 2024-09-23 17:14:03 +02:00
Refactor: Anim: replace BKE_fcurve_find() calls with new API
Nathan Vegdahl commented on pull request blender/blender#128036 2024-09-23 17:14:02 +02:00
Refactor: Anim: replace BKE_fcurve_find() calls with new API

I don't think this comment is correct, because layered actions are handled above. If we get here, that means the action is legacy.

Nathan Vegdahl commented on pull request blender/blender#128036 2024-09-23 17:14:00 +02:00
Refactor: Anim: replace BKE_fcurve_find() calls with new API

I think it might be better to just do an assert_baklava_phase_1_invariants() and not bother looping over the layers and strips at all. It's not clear to me what the semantics of this even should be outside of those conditions right now, anyway.

Nathan Vegdahl commented on pull request blender/blender#128036 2024-09-23 17:13:59 +02:00
Refactor: Anim: replace BKE_fcurve_find() calls with new API

This was a pre-existing mistake (possibly my fault...). But I'm pretty sure this should be fcurve_find_in_action_slot() or fcurve_find_in_assigned_slot() (depending on which is most convenient), because action_fcurve_ensure() also ensures for the assigned slot.

Nathan Vegdahl commented on pull request blender/blender#127920 2024-09-23 16:31:33 +02:00
Anim: update some uses of listbases of fcurves

@blender-bot build

Nathan Vegdahl pushed to fcurve_listbase_loops at nathanvegdahl/blender 2024-09-23 16:31:06 +02:00
84907d7532 Address additional in-person comments
Nathan Vegdahl pushed to fcurve_listbase_loops at nathanvegdahl/blender 2024-09-23 15:55:51 +02:00
8f583a3e95 Address PR comments
Nathan Vegdahl commented on pull request blender/blender#127920 2024-09-23 15:46:46 +02:00
Anim: update some uses of listbases of fcurves

The Collada todo in #123424 is for add_keyframes_from() and the things it impacts. This change is separate from that, and was a low-hanging fruit.