Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl pushed to main at blender/blender 2024-09-19 16:31:30 +02:00
02d0c258d9 Anim: define RNA subtypes of ActionStrip, and refine to those types
Nathan Vegdahl merged pull request blender/blender#127859 2024-09-19 16:31:29 +02:00
Anim: define RNA subtypes of ActionStrip, and refine to those types
Nathan Vegdahl commented on pull request blender/blender#127859 2024-09-19 15:08:11 +02:00
Anim: define RNA subtypes of ActionStrip, and refine to those types

@blender-bot build

Nathan Vegdahl created pull request blender/blender#127859 2024-09-19 15:07:57 +02:00
Anim: define RNA subtypes of ActionStrip, and refine to those types
Nathan Vegdahl created branch strip_rna_type_refinement in nathanvegdahl/blender 2024-09-19 15:06:28 +02:00
Nathan Vegdahl pushed to strip_rna_type_refinement at nathanvegdahl/blender 2024-09-19 15:06:28 +02:00
97e28ef307 Anim: define RNA subtypes of ActionStrip, and refine to those types
Nathan Vegdahl approved blender/blender#127414 2024-09-19 14:15:53 +02:00
Anim: Merge Animation operator
Nathan Vegdahl pushed to strip_data_removal at nathanvegdahl/blender 2024-09-19 14:00:15 +02:00
05d3414694 Merge branch 'main' into strip_data_removal
91fd95bad4 Cleanup: make strip_keyframe_data_append() doc comment accurate
214a47f15c Vulkan: Make Unused Attachments Optional
ba6126dbbd Fix #127604: Skip unlink operator for linked materials
912c6d9a3c Fix #127620: Disable smooth operator for linked objects
Compare 9 commits »
Nathan Vegdahl pushed to main at blender/blender 2024-09-19 13:57:14 +02:00
91fd95bad4 Cleanup: make strip_keyframe_data_append() doc comment accurate
Nathan Vegdahl commented on pull request blender/blender#127414 2024-09-19 12:57:00 +02:00
Anim: Merge Animation operator

See my comment up-thread: blender/blender#127414 (comment)

Basically, until we do DNA_DEFINE_CXX_METHODS on our DNA types (in this case…

Nathan Vegdahl pushed to strip_data_removal at nathanvegdahl/blender 2024-09-19 12:33:14 +02:00
d4d6d066b5 Add note about not needing to handle corner case
Nathan Vegdahl pushed to strip_data_removal at nathanvegdahl/blender 2024-09-19 12:14:38 +02:00
564fbc9231 Better doc comment
Nathan Vegdahl pushed to strip_data_removal at nathanvegdahl/blender 2024-09-19 12:07:41 +02:00
e61270c3d9 Make the strip data removal method protected
Nathan Vegdahl pushed to strip_data_removal at nathanvegdahl/blender 2024-09-19 11:58:11 +02:00
fe0dc09c23 Add unit test for strip removal with strip instances
Nathan Vegdahl pushed to strip_data_removal at nathanvegdahl/blender 2024-09-19 11:44:21 +02:00
614c4945ce Update existing removal unit test
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-19 11:09:23 +02:00
9e30e1d9b3 Update reports/2024.md
Nathan Vegdahl commented on pull request blender/blender#127414 2024-09-19 11:05:14 +02:00
Anim: Merge Animation operator

I went back to memcpy with this code. Let me know if this is sane

If you're casting to the DNA struct anyway, then it doesn't need to be a memcpy. You can just do direct assignment as in my…

Nathan Vegdahl commented on pull request blender/blender#127414 2024-09-19 11:03:25 +02:00
Anim: Merge Animation operator

It actually can do what you want, but it's (IMO) counterintuitive until you understand the pattern, and following the pattern requires DNA_DEFINE_CXX_METHODS on the DNA struct.

The way I…

Nathan Vegdahl commented on pull request blender/blender#127414 2024-09-19 10:38:08 +02:00
Anim: Merge Animation operator

I've been trying to stick to the naming convention *strip_data for these kinds of variables, since they're not the strip itself (which contains the start/end/offset) but rather the data the strip refers to (in this case keyframe data).

Nathan Vegdahl commented on pull request blender/blender#127414 2024-09-19 10:31:44 +02:00
Anim: Merge Animation operator

Yeah, ha ha.

Regarding the discussion you're referring to, I talked with @filedescriptor in person afterwards, and actually ended up addressing it differently. I do think we should do what…