- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
The Collada todo in #123424 is for add_keyframes_from() and the things it impacts. This change is separate from that, and was a low-hanging fruit.
I could have sworn that wasn't necessary. See: https://stackoverflow.com/questions/37946437/when-exactly-does-the-destruction-of-a-temporary-object-happen-in-a-function-cal
But maybe there's…
Just one place where I think the code could be clearer, which can be addressed while landing. Otherwise looks good, and kicking the tires a bit didn't reveal any issues.
If I understand correctly, what this is really saying is if (dstAdt->action == srcAdt->action). But you have to reason about the outer if's conditions to see that.
Looks good. Just a comment typo that can be fixed while landing.
Just in case, I tested on earlier versions as well. The behavior you described for 4.2 (@deadpin) goes back to at least Blender 3.6.5. I didn't bother testing earlier than that.
And I now…
Whoops, that's my goof. I must have accidentally had the action assigned to the object when I was testing 4.2.x. Thanks for catching that! I'll update the report.