Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl pushed to strip_data_storage at nathanvegdahl/blender 2024-09-17 14:56:21 +02:00
b15f990480 Fix crash when loading old slotted action files
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-17 14:17:25 +02:00
4702dbecc5 Update reports/2024.md
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-17 12:33:41 +02:00
75b295a8ef Update reports/2024.md
Nathan Vegdahl pushed to strip_data_storage at nathanvegdahl/blender 2024-09-17 11:45:26 +02:00
436e900221 Merge branch 'main' into strip_data_storage
5857238432 Fix: GPv3: Build Modifier missing object after conversion
70c0400e03 Fix: GPv3: Build Modifier crash when using object
929ccdb51f Merge branch 'main' into strip_data_storage
d5a1b02c5d Refactor: Anim, Generic functions for RNA Action Slots / Handles
Compare 37 commits »
Nathan Vegdahl approved blender/blender#127712 2024-09-16 18:13:14 +02:00
Anim: make action/slot assignment code more generic

Didn't do a super deep dive, but did read through all of the new functions added in this PR. The design and how those functions all compose looks really good to me. 👍

Nathan Vegdahl commented on pull request blender/blender#127712 2024-09-16 18:13:13 +02:00
Anim: make action/slot assignment code more generic

typo: give -> given

Nathan Vegdahl pushed to strip_data_storage at nathanvegdahl/blender 2024-09-16 17:46:09 +02:00
5f47992b4f Remove Layer::duplicate() and Strip::duplicate()
Nathan Vegdahl commented on pull request blender/blender#126559 2024-09-16 17:42:36 +02:00
Anim: change how action strip data is stored

Works a treat. Keeps the copy constructor from being used accidentally, but it can still be used (of course) explicitly, and it works just fine with MEM_new() which calls it explicitly with the…

Nathan Vegdahl pushed to strip_data_storage at nathanvegdahl/blender 2024-09-16 17:40:54 +02:00
124a2f5241 Make an explicit copy constructor for shallow Strip copies
Nathan Vegdahl commented on pull request blender/blender#126559 2024-09-16 17:24:49 +02:00
Anim: change how action strip data is stored

Talked in person. Since I'll be removing the other method that could have been the alternative, I'll just leave the comment as-is for now.

Nathan Vegdahl commented on pull request blender/blender#126559 2024-09-16 17:23:59 +02:00
Anim: change how action strip data is stored

Talked in person. I'll explore marking the copy constructor as explicit, since that will still avoid just casually copying a strip accidentally, but it might still work with MEM_new() and friends.

Nathan Vegdahl commented on pull request blender/blender#126559 2024-09-16 17:22:25 +02:00
Anim: change how action strip data is stored

Talked in person, agreed to remove both.

Nathan Vegdahl commented on pull request blender/blender#126559 2024-09-16 17:21:52 +02:00
Anim: change how action strip data is stored

Talked in person, agreed to leave it for a future PR.

Nathan Vegdahl pushed to strip_data_storage at nathanvegdahl/blender 2024-09-16 17:01:11 +02:00
35eb2eb380 Remove outdated comment
Nathan Vegdahl commented on pull request blender/blender#126559 2024-09-16 16:59:15 +02:00
Anim: change how action strip data is stored

Yeah, I could see that making sense. I do think that would be better in a separate PR, though. I'd like to try to keep the scope of this already large-ish scoped PR as small as I can, and get it…

Nathan Vegdahl pushed to strip_data_storage at nathanvegdahl/blender 2024-09-16 16:56:42 +02:00
463ced128f Make Action::strip_keyframe_data_append() protected
Nathan Vegdahl pushed to strip_data_storage at nathanvegdahl/blender 2024-09-16 15:44:39 +02:00
2d2e6741bc Clean up use of MEM_new() vs MEM_cnew()
Nathan Vegdahl pushed to strip_data_storage at nathanvegdahl/blender 2024-09-16 15:03:02 +02:00
ccea6f42b3 Rename strip_keyframe_data_num to strip_keyframe_data_array_num
Nathan Vegdahl pushed to strip_data_storage at nathanvegdahl/blender 2024-09-16 14:49:01 +02:00
40b73c238e Address some of the review comments
Nathan Vegdahl commented on pull request blender/blender#126559 2024-09-16 14:39:25 +02:00
Anim: change how action strip data is stored

As noted above, the copy constructor is (intentionally) deleted.