- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21
Found the bug and made the fix in #127565. Now just waiting on an unusually slow build bot before landing.
Honestly, I still don't like it stylistically. And I think I would want to see the summary comment when collapsing the block...? But I don't feel strongly about.
Apply Transform
operator
Confirmed broken in main. Works at least in 4.2.1, but haven't checked beyond that yet.
Basically looks good, except for one place that I think(?) is using an ifdef
when it shouldn't.
Style nit: from just the placement of the comment, it's not clear to me whether this comment is for the whole block or just for the first lines in the block. If it's for the whole block, put it just above and outside the block. If it's for the first lines, put it on its own line inside the block.
Shouldn't this be a if (action.is_layered()) {
rather than an ifdef
?
Looks good! And the tire kicking went well.