- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
Action and AnimData
Just in case you missed it: I think it would be good to rename action_slots to suitable_action_slots or similar.
Because that's how the legacy code does it (see rearrange_animchannel_add_to_islands()), and I'm just being cautious about unnecessarily diverging from the legacy code after #127108, unless I'm…
No practical reason. It's just for consistency with the channel_group_fcurve_removal test, which also doesn't actually need to use pointers, but it feels weird to me to have references that I…
It's to prevent selected items from swapping when they're up against the ends of their list and thus can't move any further. I've added comments to explain.
Note to reviewers: this branch can be removed now, because I moved the check for an action further up. But I just want a sanity check: is there any situation here where a group wouldn't be part of an action? I don't think there is, but the existence of this check here with code for both cases gave me pause.
In this case it's on purpose, so that it can return a fake group if there is no actual group. I thought that was obvious in this case, but you're right that it's better to make it clear that this…