Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl pushed to channel_group_operators at nathanvegdahl/blender 2024-09-06 11:59:29 +02:00
868bb791b0 Add asserts
Nathan Vegdahl pushed to channel_group_operators at nathanvegdahl/blender 2024-09-06 11:48:27 +02:00
2c3b3fae84 Add explantory comment
Nathan Vegdahl commented on pull request blender/blender#127080 2024-09-06 11:41:22 +02:00
Anim: implement channel grouping/moving ops for layered actions

Indeed, in retrospect neither of these are obvious. I'll add a comment explaining this.

For posterity in this PR: the two things you bring up here are actually related: it's the call to…

Nathan Vegdahl pushed to channel_group_operators at nathanvegdahl/blender 2024-09-06 11:33:30 +02:00
e7244cc12e Fix assert, and add corresponding unit tests
Nathan Vegdahl pushed to channel_group_operators at nathanvegdahl/blender 2024-09-06 11:22:07 +02:00
0d3e60b279 Documentation fix
Nathan Vegdahl commented on pull request blender/blender#127080 2024-09-06 11:18:14 +02:00
Anim: implement channel grouping/moving ops for layered actions

Also, I went to go add a case to the unit tests for this method, and discovered... I forgot to make a unit test for it!

Nathan Vegdahl commented on pull request blender/blender#127080 2024-09-06 11:16:35 +02:00
Anim: implement channel grouping/moving ops for layered actions

Because I'm a goofball! Thanks for catching that.

Nathan Vegdahl pushed to fix_layered_channel_indentation at nathanvegdahl/blender 2024-09-06 11:08:42 +02:00
96859888cf Fix another comment
Nathan Vegdahl pushed to fix_layered_channel_indentation at nathanvegdahl/blender 2024-09-06 11:07:03 +02:00
9fab0b2043 Fix typo in comment
Nathan Vegdahl pushed to fix_layered_channel_indentation at nathanvegdahl/blender 2024-09-06 11:03:40 +02:00
98d361d031 Better comments
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-06 10:36:33 +02:00
418493dec4 Update reports/2024.md
Nathan Vegdahl commented on issue blender/blender#124399 2024-09-06 10:35:03 +02:00
RNA APIs for Action and AnimData

Also the layout.template_search() call for the property selector relies on having a single RNA property that can produce the values it presents.

Oh, so is the primary reason for this…

Nathan Vegdahl approved blender/blender#127185 2024-09-06 10:29:35 +02:00
Anim: update descriptions for slot-related properties

Happy to land this as-is for now, with the caveat that I would like us to remove last_slot_handle from RNA before Baklava makes its way into an official release.

Nathan Vegdahl commented on pull request blender/blender#127185 2024-09-06 10:27:48 +02:00
Anim: update descriptions for slot-related properties

Ooooh, that makes sense now. Thanks for the description.

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-05 17:56:10 +02:00
40da77761c Update reports/2024.md
Nathan Vegdahl created pull request blender/blender#127202 2024-09-05 17:55:24 +02:00
Fix: incorrect indentation in action editor with layered actions
Nathan Vegdahl pushed to fix_layered_channel_indentation at nathanvegdahl/blender 2024-09-05 17:54:38 +02:00
ac7da3b297 Fix: incorrect indentation in action editor with layered actions
b2fdae6f0e Vulkan: GPU depth picking
a5cb4a6ae3 Fix (unreported) broken do_version on particles settings for very old files.
3d2408fb4e Tests: blendfile versioning: print loaded file/linked ID by default.
eeefd9a69c Vulkan: Enable render tests
Compare 10 commits »
Nathan Vegdahl created branch fix_layered_channel_indentation in nathanvegdahl/blender 2024-09-05 17:54:37 +02:00
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-05 15:23:54 +02:00
52c84050e2 Update reports/2024.md
Nathan Vegdahl commented on pull request blender/blender#127188 2024-09-05 15:22:29 +02:00
Anim: Convert FCurve groups from legacy to layered

One thing to note: this has quadratic performance due to the call to fcurve_assign_to_channel_group() in the loop, which itself has linear performance. I think that's fine for now, and we can…