Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl approved blender/blender#127188 2024-09-05 15:20:55 +02:00
Anim: Convert FCurve groups from legacy to layered

Looks good to me, and works in testing.

Nathan Vegdahl commented on pull request blender/blender#126655 2024-09-05 15:12:00 +02:00
Anim: Reuse action between related data

I think a for loop is actually better, for the same reason you gave. Just needs a comment to clarify, I think.

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-05 14:55:31 +02:00
d1184cf12f Update reports/2024.md
Nathan Vegdahl pushed to channel_group_operators at nathanvegdahl/blender 2024-09-05 14:46:36 +02:00
7c22733fe5 Misc cleanups
Nathan Vegdahl pushed to channel_group_operators at nathanvegdahl/blender 2024-09-05 12:52:19 +02:00
beb9112985 Add unit tests for ChannelBag::channel_group_move()
Nathan Vegdahl pushed to channel_group_operators at nathanvegdahl/blender 2024-09-05 12:24:38 +02:00
e5993b5835 Add unit tests for ChannelBag::fcurve_ungroup()
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-05 11:44:16 +02:00
3e1d776dff Update reports/2024.md
Nathan Vegdahl approved blender/blender#127112 2024-09-05 11:43:29 +02:00
Anim: Slot Removal

Looks good to me! Just one suggestion that you can address while landing if you like.

Nathan Vegdahl commented on pull request blender/blender#127112 2024-09-05 11:43:28 +02:00
Anim: Slot Removal

Feel free to ignore, because it doesn't really matter that much. But in general I've been trying to lean on Span's methods for this kind of stuff when it exists. In this case:

Nathan Vegdahl suggested changes for blender/blender#126655 2024-09-05 11:03:50 +02:00
Anim: Reuse action between related data

Looking good! I'm mostly just missing some documentation/comments.

Nathan Vegdahl commented on pull request blender/blender#126655 2024-09-05 11:03:49 +02:00
Anim: Reuse action between related data

I really like this solution! Very elegant, IMO.

Nathan Vegdahl commented on pull request blender/blender#126655 2024-09-05 11:03:47 +02:00
Anim: Reuse action between related data

This doc comment needs to be updated, since it now also searches indirect users.

Nathan Vegdahl commented on pull request blender/blender#126655 2024-09-05 11:03:46 +02:00
Anim: Reuse action between related data

I think the name should be plural, unless I'm misunderstanding the code. add_object_data_users

Nathan Vegdahl commented on pull request blender/blender#126655 2024-09-05 11:03:45 +02:00
Anim: Reuse action between related data

Probably could use some more unit tests as well to test at least one or two of the more complex cases.

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-03 18:23:00 +02:00
431f240762 Update reports/2024.md
Nathan Vegdahl pushed to channel_group_operators at nathanvegdahl/blender 2024-09-03 18:16:48 +02:00
48c9bc4c8b Update "Move Channels" operator to work with layered-action fcurves
Nathan Vegdahl pushed to channel_group_operators at nathanvegdahl/blender 2024-09-03 17:06:42 +02:00
9c110b50d4 Update "Move Channels" operator to work with layered-action channel groups
Nathan Vegdahl deleted branch channel_groups_in_graph_editor from nathanvegdahl/blender 2024-09-03 15:49:06 +02:00
Nathan Vegdahl pushed to main at blender/blender 2024-09-03 15:49:04 +02:00
56e5b61ad0 Fix: layered-action channel groups not shown in graph editor
Nathan Vegdahl merged pull request blender/blender#127108 2024-09-03 15:49:03 +02:00
Fix: layered-action channel groups not shown in graph editor