Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl commented on pull request blender/blender#127075 2024-09-02 14:40:14 +02:00
Fix: deleting fcurve in a group creates inconsistent group state

@blender-bot build

Nathan Vegdahl created pull request blender/blender#127075 2024-09-02 14:39:56 +02:00
Fix: deleting fcurve in a group creates inconsistent group state
Nathan Vegdahl created branch fix_channel_group_deletion_bug in nathanvegdahl/blender 2024-09-02 14:37:40 +02:00
Nathan Vegdahl pushed to fix_channel_group_deletion_bug at nathanvegdahl/blender 2024-09-02 14:37:40 +02:00
97fcd4a6fb Fix: deleting fcurve in a group creates inconsistent group state
e291f8230a Fix: range selecting any animation channels always selects slots
a2e580c0c1 Cleanup: Correct comment on memory utility function
9074da6457 Fix: memory leak when converting vfont to curve
f917b60036 Anim: add Action selectors to Material + Camera properties
Compare 10 commits »
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-02 13:53:31 +02:00
4886c6b9ec Update reports/2024.md
Nathan Vegdahl deleted branch fix_slot_channel_selection_bug from nathanvegdahl/blender 2024-09-02 13:41:15 +02:00
Nathan Vegdahl merged pull request blender/blender#126981 2024-09-02 13:41:10 +02:00
Fix: range selecting any animation channels always selects slots
Nathan Vegdahl pushed to main at blender/blender 2024-09-02 13:41:09 +02:00
e291f8230a Fix: range selecting any animation channels always selects slots
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-02 12:58:50 +02:00
e4f6312a8b Update reports/2024.md
Nathan Vegdahl commented on pull request blender/blender#126981 2024-09-02 12:57:57 +02:00
Fix: range selecting any animation channels always selects slots

@blender-bot build

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-09-02 12:10:23 +02:00
3495705f42 Update reports/2024.md
Nathan Vegdahl commented on pull request blender/blender#126655 2024-09-02 11:29:03 +02:00
Anim: Reuse action between related data

An approach that might(?) help simplify the code, or at least make it easier to follow, is to have a function that (given an ID) returns a priority-ordered list of other IDs to check for actions. …

Nathan Vegdahl suggested changes for blender/blender#126655 2024-09-02 11:22:12 +02:00
Anim: Reuse action between related data

Reading through the code, one thing that occurred to me is that I don't think this is keying-order invariant. In other words, the code as it is right now will result in different action arrangements (what does and doesn't share an action) depending on the order you key things in.

Nathan Vegdahl commented on pull request blender/blender#126655 2024-09-02 11:22:11 +02:00
Anim: Reuse action between related data

Can this ever be null? I might be misunderstanding the code, but it looks to me like this could be an assert instead.

Nathan Vegdahl commented on pull request blender/blender#126655 2024-09-02 11:22:09 +02:00
Anim: Reuse action between related data

Might be worth putting a comment at the top of each case explaining its intent (e.g. "search for an action already assigned to the object's data").

Nathan Vegdahl created pull request blender/blender#126981 2024-08-30 15:58:43 +02:00
Fix: range selecting any animation channels always selects slots
Nathan Vegdahl pushed to fix_slot_channel_selection_bug at nathanvegdahl/blender 2024-08-30 15:57:36 +02:00
a2c3e041d5 Fix: range selecting any animation channels always selects slots
e8e89b751d Vulkan: Fix incorrect reordering when copying attachment
05f2e6f5c2 Fix #125988: File output node not using output node color
6c7ef54211 Fix (unreported) BKE_main_namemap_get_name not always returning true when modifying given name.
515843ff3a Fix: crash after saving file with 2+ layered-action channel groups
Compare 7 commits »
Nathan Vegdahl created branch fix_slot_channel_selection_bug in nathanvegdahl/blender 2024-08-30 15:57:36 +02:00
Nathan Vegdahl approved blender/blender#126943 2024-08-30 15:40:44 +02:00
Anim: New/Un-assign Slot operators

Basically looks good from what I can see. Just a documentation copy-paste error that can be fixed while landing.

Nathan Vegdahl commented on pull request blender/blender#126943 2024-08-30 15:40:43 +02:00
Anim: New/Un-assign Slot operators

Copy-paste error: not "get this slot", but something like "get its slot connection cleared".