- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
Ah! Thanks. I just copy-pasted that from the existing functions without really thinking about it (I think it's also unneeded there? But I'll leave those ones alone since they're not part of…
Looks good to me, and fixes the bug in testing.
I assume you did test the forward compatibility part of this PR?
Yes. The files open correctly with the channel groups at least in 3.6.5, 4.1.1, and 4.2.1. They don't open correctly in…
I think we just need to address the TODO, and then this is good to land.
I think we probably should address this TODO before landing. If I understand correctly, as-is this will let the user unlink an action from an ID even if that ID is supposedly non-editable due to being library-linked with no overrides.
Since this PR is being continued in #126561, I'm closing this one.
Yeah, I figured so. I messed around for a minute or so, but wasn't able to get anything to happen. I believe you and the reporter, though. ;-)
I can't seem to reproduce the bug this is fixing on main (even with the provided blend file in the issue), so I can't verify in that sense. Both main and this PR behave the same for me.
Fixes the build issue for me. Not familiar with that area of the code, so can't say much about that side of things.