Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-20 11:15:49 +02:00
ba4b70852b Make sure legacy group create/delete/move code doesn't run for layered actions
Nathan Vegdahl commented on pull request blender/blender#125774 2024-08-20 10:35:50 +02:00
Anim: add channel groups to layered actions

Thanks for catching that!

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-08-19 18:01:54 +02:00
b04263cf70 Update reports/2024.md
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-08-19 17:59:31 +02:00
24e8d0f4d2 Update reports/2024.md
Nathan Vegdahl commented on issue blender/blender-addons#52758 2024-08-19 12:02:26 +02:00
Rigify: feature proposal: allow registration of custom rig types

@Pierre_Schiller

Yes, if you go to the n-panel in the 3d viewport there should be a Rigify tab, and the dev tools panel is in that tab.

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-08-16 18:10:47 +02:00
69229b60e0 Update reports/2024.md
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-08-16 18:10:32 +02:00
6d7bfee53f Update reports/2024.md
Nathan Vegdahl commented on pull request blender/blender#125774 2024-08-16 16:52:18 +02:00
Anim: add channel groups to layered actions

@mont29 Added you for review specifically for the RNA iterator stuff that we already discussed. Feel free to ignore the rest of the PR if you don't have the time or desire.

Nathan Vegdahl commented on pull request blender/blender#126399 2024-08-16 15:58:50 +02:00
Fix #126140: Cycle aware keying not working

Looks good! Feel free to land.

Nathan Vegdahl commented on pull request blender/blender#126399 2024-08-16 15:50:42 +02:00
Fix #126140: Cycle aware keying not working

Ha ha. I'm having great luck with my timing on making comments today. 😆

Nathan Vegdahl approved blender/blender#126399 2024-08-16 15:49:34 +02:00
Fix #126140: Cycle aware keying not working

Looks good to me, unless you want to play with changing remap_cyclic_keyframe_location() to be purely functional as I was suggesting. Don't feel obligated, though. Feel free to land as-is if you'd rather not bother, or if it ends up getting messy.

Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:46:01 +02:00
5374e5e58f Yet more elaboration
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:43:32 +02:00
052bb7ee9e A bit more elaboration in the last comment
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:39:43 +02:00
276d1c6411 Add comment about the invariants of channel groups
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:35:21 +02:00
6cae6832b1 Remove comment that I added on a whim for myself
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:24:12 +02:00
92bb33dc65 Change channel_group_containing_index() to return the group index
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:08:51 +02:00
5c9c155a3c Remove unused ReportList * parameter from RNA function
Nathan Vegdahl pushed to layered_action_fcurve_groups at nathanvegdahl/blender 2024-08-16 15:02:30 +02:00
b6aa2082b6 Improve code docs
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-08-16 14:28:25 +02:00
0f855aa24d Update reports/2024.md
Nathan Vegdahl suggested changes for blender/blender#126399 2024-08-16 14:27:04 +02:00
Fix #126140: Cycle aware keying not working

I think this is fine for now, yeah. I'm not sure if I agree that it really belongs in this function, but I also just generally feel that it's pretty unclear right now what's responsible for what anyway, and we'll probably want to do some refactoring at some point to sort that out. So I think this is a fine fix given the current state of the code.