- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
The comment here suggests that this line was here to affect the behavior of insert_vert_fcurve(), which it's now been moved into. Can you confirm whether this line has any effect anymore? Because at least at a glance, I can't see anywhere that this flag is used after this point. If we can just kill this line altogether that would be great.
So it turns out it would be a bit annoying to completely remove it, since then I'd have to duplicate the calls needed to just to basic removal of an element from an array. But I did simplify it…
Just to be extra clear: yes, please just land as-is.
I'm probably giving mixed messages by continuing to discuss things, but I'm really just continuing the discussion for how we might want to…
Yeah, go ahead and land it as-is. I don't think it makes sense to block PRs on relatively minor and subjective things like this.
but having a separate function allows me to go by function…
That's totally fair! Not to block landing this in any way (just for the sake of discussion), I do, however, want to make a case for more liberal use of lambdas in c++ code:
I think one of the…
I think we can keep this open as a known issue.
There's no way to completely solve it in a robust mathematical sense, but I suspect we could do something like find the multiple-of-360 offset…
since quaternions seem to "ease in ease out" even when set to linear.
Yeah, that happens when there are large angles between the keys. If you key every 90 degrees instead, that effect is…
Aside from the one comment, which you can decide how to address while landing, looks good to me! Thanks for tracking this down!
Not super thrilled about losing the constness here. Especially in the spaghetti that is the animation filtering code, knowing that something can't be changed is really helpful in following the code.
I would also like to ask @ChengduLittleA by setting the quaternion three times and three key points, 360 degrees can be completed, but it still cannot be achieved. I don't know why
The WXYZ…
Good call. I also renamed the new fields in bActionGroup, because one of them was also named fcurve_index.
The old animation system is so funny:
Indeed, you can't directly create groups with an empty string name. It will instead name it "Group", "Group.001", etc. as needed. But nothing stops you…
It's so that if the fcurve needs to be created, it gets put in the right group. Similar to how prop_subtype lets us know what color mode to create the fcurve with. Neither are needed for…