Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl commented on pull request blender/blender#124996 2024-07-22 12:19:26 +02:00
Anim: Backward compatibility API for Action.fcurves

Poke.

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-07-22 12:08:34 +02:00
c3d25fc910 Update reports/2024.md
Nathan Vegdahl approved blender/blender#125065 2024-07-22 12:07:34 +02:00
Anim: forward compatibility for F-Curves in layered Actions

Looks good to me. Just (what I think is) an outdated doc comment, and a super tiny nit about another comment, both of which can be addressed while landing.

Nathan Vegdahl commented on pull request blender/blender#125065 2024-07-22 12:07:33 +02:00
Anim: forward compatibility for F-Curves in layered Actions

Super nit picky: for some reason my brain parses and relates this comment to the code better if it's phrased, "Read legacy data if needed."

Nathan Vegdahl commented on pull request blender/blender#125065 2024-07-22 12:01:35 +02:00
Anim: forward compatibility for F-Curves in layered Actions

Just repeating: I think this doc comment is out of date. It refers to a T type parameter, but this function isn't templatized, and is instead specific to FCurve.

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-07-22 10:47:40 +02:00
ac93e9633c Update reports/2024.md
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-07-22 10:44:02 +02:00
cb3870c04f Update reports/2024.md
Nathan Vegdahl deleted branch fix_legacy_action_key_insert_on_layered_actions from nathanvegdahl/blender 2024-07-19 16:56:47 +02:00
Nathan Vegdahl merged pull request blender/blender#125055 2024-07-19 16:56:43 +02:00
Fix: key insertion sometimes treats layered actions as legacy actions
Nathan Vegdahl pushed to main at blender/blender 2024-07-19 16:56:42 +02:00
9f944fe53c Fix: key insertion sometimes treats layered actions as legacy actions
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-07-19 16:55:55 +02:00
f32f2ef759 Update reports/2024.md
Nathan Vegdahl commented on pull request blender/blender#125055 2024-07-19 16:30:40 +02:00
Fix: key insertion sometimes treats layered actions as legacy actions

@blender-bot build

f86beadaac baction -> dna_action
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-07-19 15:19:30 +02:00
bd91e439f8 Update reports/2024.md
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-07-19 15:19:19 +02:00
6c5d1dd8a9 Update reports/2024.md
Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-07-19 15:10:00 +02:00
6b021f07dc Update reports/2024.md
Nathan Vegdahl suggested changes for blender/blender#125065 2024-07-19 14:57:46 +02:00
Anim: forward compatibility for F-Curves in layered Actions

I think there's some cleanup left to do in this PR. Aside from the things that need to be cleaned up, it basically looks good to me as far as I can follow it. But I'll give it another pass after the cleanup.

Nathan Vegdahl commented on pull request blender/blender#125065 2024-07-19 14:57:45 +02:00
Anim: forward compatibility for F-Curves in layered Actions

This feels like it belongs with the other BLI_listbase functions. Although admittedly it would need a clearer, more distinct name then. Not sure if it's actually worth moving there or not, but just wanted to mention it.

Nathan Vegdahl commented on pull request blender/blender#125065 2024-07-19 14:57:44 +02:00
Anim: forward compatibility for F-Curves in layered Actions

It looks like this function used to be templatized by T, but now isn't, and the documentation didn't get updated yet.

Nathan Vegdahl commented on pull request blender/blender#125065 2024-07-19 14:57:43 +02:00
Anim: forward compatibility for F-Curves in layered Actions

There are a whole lot of printf()s like this is this PR. Are they intentionally left in? And if so, why? Don't they result in a bunch of console spam during blend file IO?