Nathan Vegdahl nathanvegdahl
3 Followers · 0 Following
  • Amsterdam, Netherlands
  • https://cessen.com

  • Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.

    Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).

  • Joined on 2003-03-21
Overview Repositories
8
 Projects Public Activity Starred Repositories
Nathan Vegdahl commented on pull request blender/blender#124619 2024-07-16 11:37:41 +02:00
Fix: Layered Action - deleting keys not working without keyingset

My first reaction was that this call isn't right for layered actions. That function is supposed to be specific to legacy actions. But in practice it doesn't hurt anything right now, because it will just fail to find the fcurve in the legacy action fcurves and skip the legacy-specific stuff anyway.

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-07-16 11:14:48 +02:00
1a2f29c16d Update reports/2024.md
Nathan Vegdahl created pull request blender/blender#124733 2024-07-15 17:19:06 +02:00
WIP: Result type for return-value-based error handling
Nathan Vegdahl pushed to result at nathanvegdahl/blender 2024-07-15 17:09:39 +02:00
6c9af3ad23 Add some documentation
Nathan Vegdahl pushed to result at nathanvegdahl/blender 2024-07-15 14:59:34 +02:00
cdb8eb4393 Initial crack at a Result type
Nathan Vegdahl pushed to result at nathanvegdahl/blender 2024-07-15 14:54:55 +02:00
dd48b63365 Initial crack at a Result type
Nathan Vegdahl created branch result in nathanvegdahl/blender 2024-07-15 14:54:55 +02:00
Nathan Vegdahl commented on pull request blender/blender#124619 2024-07-15 10:46:58 +02:00
Fix: Layered Action - deleting keys not working without keyingset

Not for this PR, but just noting:

Looking at both this and #124598, it appears to me that we have a similar situation with keyframe deletion as we did (and still do in many areas) with keyframe…

Nathan Vegdahl pushed to main at nathanvegdahl/.profile 2024-07-15 10:30:19 +02:00
97d068a91c Update reports/2024.md
Nathan Vegdahl deleted branch baklava_delete_keys_on_buttons from nathanvegdahl/blender 2024-07-15 10:27:07 +02:00
Nathan Vegdahl merged pull request blender/blender#124598 2024-07-15 10:27:04 +02:00
Fix: deleting keys on buttons doesn't work with layered actions
Nathan Vegdahl pushed to main at blender/blender 2024-07-15 10:27:04 +02:00
b792515644 Fix: deleting keys on buttons doesn't work with layered actions
Nathan Vegdahl commented on pull request blender/blender#124598 2024-07-15 09:51:05 +02:00
Fix: deleting keys on buttons doesn't work with layered actions

@blender-bot build

Nathan Vegdahl pushed to baklava_delete_keys_on_buttons at nathanvegdahl/blender 2024-07-15 09:46:54 +02:00
166f9513ac Merge branch 'main' into baklava_delete_keys_on_buttons
8fcd1812b4 Merge branch 'blender-v4.2-release'
cb66c9623c Merge branch 'blender-v4.2-release'
988bf2b88f Fix incorrect exception message on collection key type error
742943f554 Fix: error in previus commit 7249b7
Compare 56 commits »
Nathan Vegdahl commented on pull request blender/blender#124598 2024-07-12 16:39:55 +02:00
Fix: deleting keys on buttons doesn't work with layered actions

Ah, got it! Yeah, for sure.

Nathan Vegdahl commented on pull request blender/blender#124598 2024-07-12 16:38:12 +02:00
Fix: deleting keys on buttons doesn't work with layered actions

@blender-bot build

Nathan Vegdahl commented on pull request blender/blender#124598 2024-07-12 16:33:54 +02:00
Fix: deleting keys on buttons doesn't work with layered actions

I think that's still the case here: every call to fcurve_find just does a linear scan of fcurves.

However, the number of array property elements getting keyed can (I think?) effectively be…

Nathan Vegdahl pushed to baklava_delete_keys_on_buttons at nathanvegdahl/blender 2024-07-12 15:59:28 +02:00
603fa73e31 Better documentation.
Nathan Vegdahl pushed to baklava_delete_keys_on_buttons at nathanvegdahl/blender 2024-07-12 15:41:00 +02:00
c7a76ce5d7 Remove unnecessary const from function declarations
Nathan Vegdahl pushed to baklava_delete_keys_on_buttons at nathanvegdahl/blender 2024-07-12 15:37:03 +02:00
ad6dfc39c7 Don't reformat already existing note