- Amsterdam, Netherlands
- https://cessen.com
-
Animator, rigger, and software developer. Currently working at the Blender Institute as a developer on Blender's animation system.
Been using Blender since 1998, and worked on Big Buck Bunny and Sintel (two of Blender's open movie projects).
- Joined on
2003-03-21 -
-
After discussing with @ChrisLend, we've decided to add an option to the Limit Rotation constraint to bring back the old behavior. Because although the old behavior was broken in the general case,…
After investigating folding the PropertySubType parameter into KeyframeSettings, it became clear that it would be rather awkward after all. However, it does make sense to fold it into a new…
I suspect this is the cause for the difference from 3.4 to 3.5: d9192aaa6d
If that does turn out to be the cause, that will be quite embarrassing, as it's my commit. Ha ha. :-) I could have…
Ah, it was the Developer Extras bit that I forgot about. In all the other versions that was already ticked on for me, so it didn't occur to me. Thanks!
I talked to @Hjalti about this, and indeed there is a good use case for the current behavior.
Imagine you have a very heavy scene, with e.g. complex heavy rigs, etc. You also have a sequencer…
bDopesheet *ads parameter
Looks good to me! Just a minor nit about where to put a TODO, which can be addressed (or not, if you disagree) while landing.
bDopesheet *ads parameter
I think this TODO should be on the struct definition itself, or at least also there.
bDopesheet *ads parameter
I really appreciate these asserts. 👍
Change in plans:
After further investigation I've come to the conclusion that the old "broken" behavior is in fact a meaningful interpretation of "limit rotation" in the context of local-space…
Oh, yeah, that would do it! Ha ha. Thanks for catching that. And good to know that the fast hash is in fact good enough for screen-space blue noise applications when properly seeded.
I wasn't clear enough in one of my comments, and thus you didn't fully address it. More in the comment thread itself.
Looks good. But I should have been clearer: I also meant for act_keyframes_loop() below to get renamed accordingly. E.g. action_legacy_keyframes_loop().