Olivier C oliverpool
  • Joined on 2023-05-05
Olivier C deleted branch temp-windows-fixes from oliverpool/blender-asset-tracer 2024-01-10 16:38:27 +01:00
Olivier C deleted branch shaman from oliverpool/blender-asset-tracer 2024-01-10 16:38:24 +01:00
Olivier C deleted branch ies_support from oliverpool/blender-asset-tracer 2024-01-10 16:38:18 +01:00
Olivier C commented on issue blender/blender-asset-tracer#92881 2024-01-10 16:37:55 +01:00
Imported VDBs not packing in Blender Asset Tracer

This has been merged in #92884 (only in main, not released yet).

With a caveat regarding VDB marked as packed inside blender: blender/blender-asset-tracer#9

Olivier C pushed to fix_ies_blocks2assets at oliverpool/blender-asset-tracer 2024-01-10 16:34:14 +01:00
118353ed0b add CHANGELOG
335d0c4ec3 Fix IES lights blocks2assets
Compare 2 commits »
Olivier C deleted branch external_vdb from oliverpool/blender-asset-tracer 2024-01-10 16:32:28 +01:00
Olivier C pushed to fix_ies_blocks2assets at oliverpool/blender-asset-tracer 2024-01-10 16:32:23 +01:00
532856a550 add CHANGELOG
Olivier C commented on pull request blender/blender-asset-tracer#92886 2024-01-10 16:30:03 +01:00
Fix IES lights blocks2assets

Hi, I was away for vacations. I will try to help get this PR through.

I reworked my PR:

  • rebased on main (to resolve the conflicts)
  • the test commit now uses the file shared by @ariane-genty…
Olivier C pushed to fix_ies_blocks2assets at oliverpool/blender-asset-tracer 2024-01-10 16:27:18 +01:00
176af17445 Fix IES lights blocks2assets
531e2784a1 add IES test
15f00e6c92 Add support for reading uchar aka uint8_t
ced4af98a3 Add support for OpenVDB
937ecfdece Update CHANGELOG
Compare 7 commits »
Olivier C commented on pull request blender/blender-asset-tracer#92884 2023-12-15 17:33:01 +01:00
Add support for Open VDB

Fair enough. Do you think that the issue blender/blender#100592 pointed out by @ariane-genty is the right one for this bug? Or should another issue be opened?…

Olivier C commented on pull request blender/blender-asset-tracer#92885 2023-12-15 14:20:49 +01:00
blocks2assets: debug filepath on reading unsupported blocks

This one is still missing, though.

Sorry, I overlooked this part of your comment.

You can use the .blend file of #92884: [scene_with_vdb_and_fluid_cache.zip](https://projects.blender.org/a

Olivier C commented on pull request blender/blender-asset-tracer#92884 2023-12-15 14:16:48 +01:00
Add support for Open VDB

A "BAT pack" is something completely different than "packed files inside a blend file".

On which of this feature does the @skip_packed decorator act?

I thought that @skip_packed

Olivier C pushed to external_vdb at oliverpool/blender-asset-tracer 2023-12-15 14:16:10 +01:00
2024845082 Add support for Open VDB
47e7c00845 Bumped version to 1.17
1abb8e5650 Mark 1.17 as released today
61dc5b8a23 Fix issue packing lamps with non-IES 'storage'
81ea8296da Bump version to 1.17-dev0
Compare 5 commits »
Olivier C opened issue blender/blender-asset-tracer#92887 2023-12-15 11:18:12 +01:00
Add automated testing (to run the existing tests) and document how to run them locally
Olivier C commented on pull request blender/blender-asset-tracer#92883 2023-12-15 11:12:07 +01:00
Add support for IES lighting

I added a test in #92886 for a relative Lamp inside and outside of the project (the test that was in our pipeline).

Feel free to add a testcase for your commit 61dc5b8a23 as well

Olivier C commented on pull request blender/blender-asset-tracer#92886 2023-12-15 11:07:47 +01:00
Fix IES lights blocks2assets

Found out that running poetry run pytest -k test_pack_ies_external --no-cov was what I wanted.

I rebased on top of main and reordered the commits to show that running the test above on…

Olivier C pushed to fix_ies_blocks2assets at oliverpool/blender-asset-tracer 2023-12-15 11:06:45 +01:00
54fd4d6aea Fix IES lights blocks2assets
0ad1e0fa36 add IES test
47e7c00845 Bumped version to 1.17
1abb8e5650 Mark 1.17 as released today
61dc5b8a23 Fix issue packing lamps with non-IES 'storage'
Compare 6 commits »
Olivier C commented on pull request blender/blender-asset-tracer#92886 2023-12-15 10:30:40 +01:00
Fix IES lights blocks2assets

Sure, how can I run the tests ? (I couldn't find any doc regarding them)

Olivier C commented on pull request blender/blender-asset-tracer#92884 2023-12-15 10:17:25 +01:00
Add support for Open VDB

So this seems to be an issue with Blender, then?

Probably (I have to confess that my experience with blender is very limited, I am a software developer and not a 3D artist)

How should we…

Olivier C commented on pull request blender/blender-asset-tracer#92885 2023-12-15 10:08:24 +01:00
blocks2assets: debug filepath on reading unsupported blocks

I implemented your suggestion and rebased on top of main (hence the force-push)