Miguel Pozo pragma37
  • Joined on 2018-04-26
Miguel Pozo commented on pull request blender/blender#107176 2023-08-02 18:51:48 +02:00
EEVEE Next: Volumes

But the volume resolve is not part of the forward pipeline at all?

I actually think we eventually will have to go in the opposite direction. The final ShadingView::render order should be…

Miguel Pozo commented on pull request blender/blender#107176 2023-08-02 18:42:08 +02:00
EEVEE Next: Volumes

So the world volume should be deferred but the world itself don't, is that right?

Miguel Pozo commented on pull request blender/blender#107176 2023-08-02 18:40:00 +02:00
EEVEE Next: Volumes

There is a bit of a design problem when things to too much effect centric instead of being data centric.

The problem is that trying to force the volume pipeline into the geometry pipeline…

Miguel Pozo pushed to pull-eevee-next-volumes at pragma37/blender 2023-08-02 18:39:02 +02:00
f07ba42ce7 Move pipelines.world_volume.sync call to World class
94a844af99 Add MaterialPass volume to Material
Compare 2 commits »
Miguel Pozo commented on pull request blender/blender#110313 2023-08-02 16:37:25 +02:00
EEVEE Next: Overscan support

Maybe one last polish you can do, is to reset TAA if overscan changes, because the motion vectors are wrong in this case.

Unless I'm missing something, Film::init already takes care of…

Miguel Pozo commented on pull request blender/blender#110386 2023-08-02 16:31:19 +02:00
EEVEE-Next: Irradiance Bake: Add validity based dilation

Just confirming that the committed fix does, indeed, solve the issue on my end.

Miguel Pozo commented on pull request blender/blender#110703 2023-08-02 16:30:10 +02:00
EEVEE Next: Sculpt support

@HooglyBoogly That code only runs after a brush stroke, and only if the PBVH is in PBVH_FACE mode, which didn't seem to be the case when I've debugged it. In any case, even forcing it to run…

Miguel Pozo created pull request blender/blender#110703 2023-08-01 20:34:40 +02:00
EEVEE Next: Sculpt support
Miguel Pozo pushed to pull-eevee-next-volumes at pragma37/blender 2023-08-01 20:21:39 +02:00
efb353b640 Fix world volume shader resource bindings
b6e3301218 Cleanup material_create_info_ammend
6239db1818 Cleanups
61d1a702ec Fix object_sync
f7a9846912 Merge branch 'main' into pull-eevee-next-volumes
Compare 297 commits »
Miguel Pozo commented on pull request blender/blender#110114 2023-08-01 19:05:31 +02:00
EEVEE Next: Motion Blur fixes

Oooops! Done. :)

Miguel Pozo pushed to pull-eevee-next-motion-blur-fixes at pragma37/blender 2023-08-01 19:04:50 +02:00
6b2c99ff46 Cleanup
Miguel Pozo pushed to pull-eevee-next-overscan at pragma37/blender 2023-08-01 19:01:01 +02:00
5eed576f38 Cleanup camera_sync and add RE_GetWindowMatrixWithOverscan
Miguel Pozo commented on pull request blender/blender#110114 2023-08-01 17:58:30 +02:00
EEVEE Next: Motion Blur fixes

How about moving the comment to the header file?

/* Perform VelocityGeometryData offset computation and copy into the geometry step buffer.
 * Should be called after all the vertex…
Miguel Pozo commented on pull request blender/blender#110313 2023-08-01 17:48:21 +02:00
EEVEE Next: Overscan support

Honestly, I'm not a big fan of splitting viewport/render code like that if it isn`t necessary. We have plenty of bugs/regressions of features working in the viewport but not on render, and I…

Miguel Pozo pushed to pull-eevee-next-overscan at pragma37/blender 2023-08-01 17:43:57 +02:00
c6afa8c3af Cleanup
Miguel Pozo commented on pull request blender/blender#110114 2023-08-01 17:19:07 +02:00
EEVEE Next: Motion Blur fixes

I've added it back to geometry_steps_fill. I've removed the "Now that vertex buffers are guaranteed to be updated", since that's not something that the function itself can actually guarantee.

Miguel Pozo pushed to pull-eevee-next-motion-blur-fixes at pragma37/blender 2023-08-01 17:15:41 +02:00
bc572dab0d Cleanups
Miguel Pozo pushed to pull-eevee-next-sculpt at pragma37/blender 2023-08-01 16:38:03 +02:00
d4b3560008 Use a valid bounding box
44d2575d22 Initial implementation
6f8ff2846f GPv3: Add API function to get active frame
79e7449a52 Cleanup: remove unused declarations
6d2326dabf Cleanup: use function style casts
Compare 45 commits »
Miguel Pozo created pull request blender/blender#110653 2023-07-31 15:41:49 +02:00
EEVEE Next: Volumes: Lighting integration improvements
Miguel Pozo pushed to pull-eevee-next-volumes-2-cleanup at pragma37/blender 2023-07-31 15:16:50 +02:00
ab0810c66b Disable shadow tagging for unlit froxels
34ffa8cc23 Volume receive shadows
6a22519f1e Volume self-shadows
d44fe479fd Irradiance
f7a9846912 Merge branch 'main' into pull-eevee-next-volumes
Compare 5 commits »