Fix visibility of instancer object #43

Merged

Bogdan Nagirniak merged 16 commits from BLEN-405_1 into hydra-render 2023-05-24 13:44:35 +02:00

Conversation 2 Commits 16 Files Changed 5 +159 -28

Georgiy Markelov commented 2023-05-19 19:16:29 +02:00

Collaborator

Copy Link

Purpose
Fix various visibility settings for objects and instances.

Technical steps

• Added static functions is_visible for InstanceData and ObjectData
• Instance visibility performed via ObjectData::update_parent()
• Fixed update on scene update
• Reworked algorithm of visibility identification

Purpose Fix various visibility settings for objects and instances. Technical steps * Added static functions `is_visible` for `InstanceData` and `ObjectData` * Instance visibility performed via `ObjectData::update_parent()` * Fixed update on scene update * Reworked algorithm of visibility identification

Georgiy Markelov added 5 commits 2023-05-19 19:16:44 +02:00

working viewport 058eacc7a5

final render c4d3435b9e

make format 14e0207e5e

removed extra line 5fb5542577

changed lines back (no needed to did it) 374845b9c1

Georgiy Markelov changed title from BLEN-405_1 to Fix visibility of instancer object 2023-05-19 19:17:30 +02:00

Georgiy Markelov self-assigned this 2023-05-19 19:17:54 +02:00

Bogdan Nagirniak was assigned by Georgiy Markelov 2023-05-19 19:17:54 +02:00

Bogdan Nagirniak added 3 commits 2023-05-22 10:43:03 +02:00

Merge branch 'hydra-render' into BLEN-405_1 e7a65d3ff6

Fixing export of visible objects 465ef3022b

Fixed visibility for Final render a18ac61a0b

Bogdan Nagirniak approved these changes 2023-05-22 10:45:31 +02:00

Bogdan Nagirniak left a comment

Owner

Copy Link

Added fixes, tested from my side.

Added fixes, tested from my side.

Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-05-22 10:45:41 +02:00

Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-05-22 10:45:42 +02:00

Bogdan Nagirniak referenced this pull request 2023-05-22 10:46:19 +02:00

Fix visibility of instancer object #40

Georgiy Markelov commented 2023-05-22 12:51:01 +02:00

Author

Collaborator

Copy Link

After fixes these checkboxes stopped working. Instances mush be hidden, because child object affects instances, created by parent (according to Cycles).

After fixes these checkboxes stopped working. Instances mush be hidden, because child object affects instances, created by parent (according to Cycles). 

image.png

377 KiB

Bogdan Nagirniak added 4 commits 2023-05-23 16:43:26 +02:00

Added logs for visibility check. Added InstancerData::is_instance_visible() af51ff7dfe

Fixed viewport visibility aec4f0a192

Fixed visibility in Final render e6874d2199

Fixed instance's visibility 9692e36fc2

Bogdan Nagirniak added 1 commit 2023-05-23 19:08:27 +02:00

Fixed instance visibility update in viewport 0e028845b4

Brian Savery (AMD) approved these changes 2023-05-24 01:55:09 +02:00

Bogdan Nagirniak added 2 commits 2023-05-24 08:50:25 +02:00

:Merge branch 'hydra-render' into BLEN-405_1 83505a4494

Adjustments after fixing merge conflicts 5b0747e763

Bogdan Nagirniak added 1 commit 2023-05-24 12:23:53 +02:00

Fixed instance visibility in special case 46ab05f378

Georgiy Markelov commented 2023-05-24 13:43:32 +02:00

Author

Collaborator

Copy Link

Tested. Works fine.

Tested. Works fine.

Bogdan Nagirniak merged commit c7463a963f into hydra-render 2023-05-24 13:44:35 +02:00

Bogdan Nagirniak referenced this issue from a commit 2023-05-24 13:44:35 +02:00

Fix visibility of instancer object

Sign in to join this conversation.

Reviewers

No reviewers

Bogdan Nagirniak

Vasyl Pidhirskyi

Brian Savery (AMD)

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

Bogdan Nagirniak

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#43

No description provided.