Fix visibility of instancer object #43

Merged

Bogdan Nagirniak merged 16 commits from BLEN-405_1 into hydra-render 2023-05-24 13:44:35 +02:00

Conversation 2 Commits 16 Files Changed 5 +159 -28

Georgiy Markelov commented 2023-05-19 19:16:29 +02:00

Collaborator

Copy Link

Purpose
Fix various visibility settings for objects and instances.

Technical steps

• Added static functions is_visible for InstanceData and ObjectData
• Instance visibility performed via ObjectData::update_parent()
• Fixed update on scene update
• Reworked algorithm of visibility identification

Purpose Fix various visibility settings for objects and instances. Technical steps * Added static functions `is_visible` for `InstanceData` and `ObjectData` * Instance visibility performed via `ObjectData::update_parent()` * Fixed update on scene update * Reworked algorithm of visibility identification

Georgiy Markelov added 5 commits 2023-05-19 19:16:44 +02:00

058eacc7a5 working viewport

c4d3435b9e final render

14e0207e5e make format

5fb5542577 removed extra line

374845b9c1 changed lines back (no needed to did it)

Georgiy Markelov changed title from BLEN-405_1 to Fix visibility of instancer object 2023-05-19 19:17:30 +02:00

Georgiy Markelov self-assigned this 2023-05-19 19:17:54 +02:00

Bogdan Nagirniak was assigned by Georgiy Markelov 2023-05-19 19:17:54 +02:00

Bogdan Nagirniak added 3 commits 2023-05-22 10:43:03 +02:00

e7a65d3ff6 Merge branch 'hydra-render' into BLEN-405_1

465ef3022b Fixing export of visible objects

a18ac61a0b Fixed visibility for Final render

Bogdan Nagirniak approved these changes 2023-05-22 10:45:31 +02:00

Bogdan Nagirniak left a comment

Owner

Copy Link

Added fixes, tested from my side.

Added fixes, tested from my side.

Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-05-22 10:45:41 +02:00

Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-05-22 10:45:42 +02:00

Bogdan Nagirniak referenced this pull request 2023-05-22 10:46:19 +02:00

Fix visibility of instancer object #40

Georgiy Markelov commented 2023-05-22 12:51:01 +02:00

Author

Collaborator

Copy Link

After fixes these checkboxes stopped working. Instances mush be hidden, because child object affects instances, created by parent (according to Cycles).

After fixes these checkboxes stopped working. Instances mush be hidden, because child object affects instances, created by parent (according to Cycles). 

image.png

377 KiB

Bogdan Nagirniak added 4 commits 2023-05-23 16:43:26 +02:00

af51ff7dfe Added logs for visibility check. Added InstancerData::is_instance_visible()

aec4f0a192 Fixed viewport visibility

e6874d2199 Fixed visibility in Final render

9692e36fc2 Fixed instance's visibility

Bogdan Nagirniak added 1 commit 2023-05-23 19:08:27 +02:00

0e028845b4 Fixed instance visibility update in viewport

Brian Savery (AMD) approved these changes 2023-05-24 01:55:09 +02:00

Bogdan Nagirniak added 2 commits 2023-05-24 08:50:25 +02:00

83505a4494 :Merge branch 'hydra-render' into BLEN-405_1

5b0747e763 Adjustments after fixing merge conflicts

Bogdan Nagirniak added 1 commit 2023-05-24 12:23:53 +02:00

46ab05f378 Fixed instance visibility in special case

Georgiy Markelov commented 2023-05-24 13:43:32 +02:00

Author

Collaborator

Copy Link

Tested. Works fine.

Tested. Works fine.

Bogdan Nagirniak merged commit c7463a963f into hydra-render 2023-05-24 13:44:35 +02:00

Bogdan Nagirniak referenced this issue from a commit 2023-05-24 13:44:35 +02:00

Fix visibility of instancer object

Sign in to join this conversation.

Reviewers

No reviewers

Bogdan Nagirniak

Vasyl Pidhirskyi

Brian Savery (AMD)

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

Bogdan Nagirniak

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#43

No description provided.