Charlie Jolly CharlieJolly
0 Followers · 0 Following
  • Joined on 2008-07-29
Repositories
2
 Projects Public Activity Starred Repositories
Charlie Jolly created branch nodecolors in CharlieJolly/blender 2024-09-27 12:20:29 +02:00
Charlie Jolly pushed to nodecolors at CharlieJolly/blender 2024-09-27 12:20:29 +02:00
b6a49e8ca1 Geometry Nodes: UI: Add dynamic node class to switch nodes
Charlie Jolly commented on pull request blender/blender#128222 2024-09-27 10:31:45 +02:00
Geometry Nodes: Improve Input Labels on Integer Math

Good spot! Thanks.

I'm not reviewer so I don't have ability to approve but this is a good to go from me.

Charlie Jolly commented on pull request blender/blender#128196 2024-09-26 18:08:38 +02:00
Function Node: Compare Node, add epsilon socket to integer data type

Just use one more compare nodes and boolean math?

Yes this is possible. Heck let's remove Not Equal operator and replace with Equal and then a Not boolean. Just one more node just makes…

Charlie Jolly commented on pull request blender/blender#128196 2024-09-26 17:47:02 +02:00
Function Node: Compare Node, add epsilon socket to integer data type

Please see use case in video so it is not meaningless. Sure they can also use or abuse math float node or compare node with float datatype. This makes things tidy from a user perspective with the…

Charlie Jolly created pull request blender/blender#128196 2024-09-26 17:11:16 +02:00
Function Node: Compare Node, add epsilon socket to integer data type
Charlie Jolly pushed to intcompare at CharlieJolly/blender 2024-09-26 17:09:23 +02:00
2fd2a3deda Function Node: Compare Node, add epsilon socket to integer data type
725b5027fb Vulkan: Refactor immediate mode
bcd0d14943 Versioning for layered actions
5f8721d92a Fix #127964: Crash when baking from mesh with no faces
a1a00ec49c Fix: Uninitialized variable in versioning code
Compare 10 commits »
Charlie Jolly created branch intcompare in CharlieJolly/blender 2024-09-26 17:09:22 +02:00
Charlie Jolly commented on pull request blender/blender#128123 2024-09-26 13:48:49 +02:00
Fix #128102: Integer Math division has only float precision

Test file showing precision fixes from this patch image

Charlie Jolly commented on pull request blender/blender#128123 2024-09-25 18:59:34 +02:00
Fix #128102: Integer Math division has only float precision

I think it is easier to keep here rather than bloat blenlib but if you want it in blenlib can you advise which file it should go?

Charlie Jolly commented on pull request blender/blender#128123 2024-09-25 18:56:56 +02:00
Fix #128102: Integer Math division has only float precision

This was derived from divide_round_i but fixed to be safe and handle negative inputs to match float output from math::round(math::safe_divide(a, b)).

I've added a comment to this affect…

Charlie Jolly pushed to fix128102 at CharlieJolly/blender 2024-09-25 18:53:52 +02:00
0d2c1bd0c9 Tidy up divide round and add function and comment
6d451798f4 Add code comment to divide round
Compare 2 commits »
Charlie Jolly pushed to fix128102 at CharlieJolly/blender 2024-09-25 18:16:03 +02:00
2665274f06 Restore safe_divide function - my bad
Charlie Jolly commented on pull request blender/blender#128123 2024-09-25 18:14:33 +02:00
Fix #128102: Integer Math division has only float precision

My mistake, I copied the function in full for testing.

Charlie Jolly pushed to main at blender/blender-manual 2024-09-25 17:48:28 +02:00
037a459fba Geometry Nodes: Add Integer Math node
Charlie Jolly created pull request blender/blender#128123 2024-09-25 16:00:11 +02:00
Fix #128102: Integer Math division has only float precision
Charlie Jolly created branch fix128102 in CharlieJolly/blender 2024-09-25 15:58:16 +02:00
Charlie Jolly pushed to fix128102 at CharlieJolly/blender 2024-09-25 15:58:16 +02:00
f23ec905d3 Fix #128102: Integer Math division has only float precision
e71c844354 Fix #127944: Normal rotates in wrong direction
2459247f9f GPv3: Enable selection operators and overlays in vertex paint mode
01825a85cb Cleanup: quiet compiler warnings
8dcd51ddc3 Fix crash in recent fix for #128104
Compare 10 commits »
Charlie Jolly commented on issue blender/blender#128102 2024-09-25 10:38:08 +02:00
Geometry Nodes: Integer Math division has only float precision

Looks like division in new integer math are done via math::safe_divide(float(a), float(b)). I guess if we really need a integer version of this safe_divide instead of converting to float in…

Charlie Jolly pushed to gn-curve-intersections at CharlieJolly/blender 2024-09-25 00:34:00 +02:00
63ec08a5c8 Calc first curve on lowest id