Jacques Lucke JacquesLucke
  • Hennigsdorf near Berlin
  • Joined on 2013-11-18
Jacques Lucke commented on pull request blender/blender#104546 2023-02-10 20:49:16 +01:00
Geometry Nodes: Operator to wrap a modifier's node group

The name is still kind of ugly. Maybe something like Move to Nodes (description: Move inputs and outputs set in the modifier to a new node group) or what Simon suggested.

Jacques Lucke commented on pull request blender/blender#104546 2023-02-10 20:49:16 +01:00
Geometry Nodes: Operator to wrap a modifier's node group

Seems like you could move the - 1 into range(...).

Jacques Lucke commented on pull request blender/blender#104546 2023-02-10 20:49:16 +01:00
Geometry Nodes: Operator to wrap a modifier's node group

Make sure vscode removes trailing spaces automatically.

Jacques Lucke commented on pull request blender/blender#104546 2023-02-10 20:49:16 +01:00
Geometry Nodes: Operator to wrap a modifier's node group

modifier may be None

Jacques Lucke commented on pull request blender/blender#104546 2023-02-10 20:49:16 +01:00
Geometry Nodes: Operator to wrap a modifier's node group

Better use two separate functions that call a common function instead of adding optional parameters to this one.

Jacques Lucke commented on pull request blender/blender#104546 2023-02-10 20:49:16 +01:00
Geometry Nodes: Operator to wrap a modifier's node group

Use get_context_modifer(context) is None.

Jacques Lucke commented on pull request blender/blender#104546 2023-02-10 20:49:16 +01:00
Geometry Nodes: Operator to wrap a modifier's node group

Avoid using input as variable name because this is a built-in function in Python.

Jacques Lucke commented on pull request blender/blender#104546 2023-02-10 20:49:15 +01:00
Geometry Nodes: Operator to wrap a modifier's node group

Can you use .x?

Jacques Lucke commented on pull request blender/blender#104431 2023-02-10 20:24:28 +01:00
Nodes: Avoid updating topology cache when changing properties

Something is wrong here, there is no return value?

Jacques Lucke commented on pull request blender/blender#104431 2023-02-10 20:24:28 +01:00
Nodes: Avoid updating topology cache when changing properties

This tag is wrong. Changing socket availability does not add/remove sockets. And if you say that making a socket available is adding the socket, then making it unavailable would also delete it.

Jacques Lucke commented on pull request blender/blender#104420 2023-02-10 20:17:20 +01:00
Fix #104219: Node links are sometimes created from the wrong socket

This is problematic, because the tree might be visible in multiple node editors, all of which would have to be updated.

Jacques Lucke commented on pull request blender/blender#104420 2023-02-10 20:17:20 +01:00
Fix #104219: Node links are sometimes created from the wrong socket

I think this could be implemented more efficiently (e.g. by storing something on bNodeSocketRuntime, or by only keeping track of the old node index which might work because the sockets of a node are consecutive in all_sockets()).

Jacques Lucke pushed to curve-parameter-falloff at JacquesLucke/blender 2023-02-10 19:51:27 +01:00
e0078644dc support spherical brush
Jacques Lucke created pull request blender/blender#104589 2023-02-10 19:49:36 +01:00
WIP: Curves: add Curve Parameter Falloff to comb brush
Jacques Lucke pushed to curve-parameter-falloff at JacquesLucke/blender 2023-02-10 19:48:53 +01:00
60f260484c initial code
Jacques Lucke created branch curve-parameter-falloff in JacquesLucke/blender 2023-02-10 19:48:53 +01:00
Jacques Lucke deleted branch parallelize-delete-geometry from JacquesLucke/blender 2023-02-10 17:14:34 +01:00