@nickberckley I think I may have misunderstood a comment in the original issue then; I took
Yes. No operations should be allowed on hidden objects (and objects in hidden collections)
To…
Only adding Julien for now, since I'm unsure of the performance impacts of this change in actual usage; if it seems satisfactory I'll look for further reviewers afterwards.
make icons causes changes to icon32_mod_explode.dat & prvicons.png
Just my two cents: I don't mind if this is kept closed for the purposes of this issue tracker, but I do think it would be valuable to have some kind of tracking for issues like this so they don't…
Should hopefully have a PR for this issue soon - I've got it working currently for individual objects being hidden, but not the hierarchy toggle.
187d522cc7
Merge branch 'main' of projects.blender.org:blender/blender into 102585-automask-toggle-icon
Updated to fix the unintended changes, I had to manually revert the icon32_mod_explode.dat and prvicons.png - still unsure at the moment as to why they change on my laptop when running `make…
Oh, I just realized I didn't change the callers; ignore review request for a bit.
I suppose an alternate option would be to have some form of overload:
std::unique_ptr<Cache> cache_init(const Sculpt *sd, Object *ob);
std::unique_ptr<Cache> cache_init(const Sculpt *sd,…I'll remove the boilerplate parameters - for the non-null pointer to reference, do you just mean changing the callers to be cache_init(s, &brush, ... ) and cache_init(s, nullptr, ...)?