blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 750 Projects 19 Wiki Activity

VSE: Add retiming tool #104544

Closed
Richard Antalik wants to merge 5 commits from iss:retiming-tool into main
pull from: iss:retiming-tool
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 6 Commits 5 Files Changed 25 +1696 -30
Richard Antalik commented 2023-02-09 21:24:58 +01:00
Member
Copy Link

This tools allows to change strip playback speed by manipulating
retiming handles. More handles can be added to single strip to create
variable playback speed.

This tool replaces Speed Factor property in time panel.

This tools allows to change strip playback speed by manipulating retiming handles. More handles can be added to single strip to create variable playback speed. This tool replaces Speed Factor property in time panel.
Richard Antalik added 1 commit 2023-02-09 21:25:00 +01:00
0859cfbd50 VSE: Add retiming tool 
This tools allows to change strip playback speed by manipulating
retiming handles. More handles can be added to single strip to create
variable playback speed.

This tool replaces Speed Factor property in time panel.
Richard Antalik requested review from Sergey Sharybin 2023-02-09 21:25:19 +01:00
Julien Kaspar added a new dependency 2023-02-09 22:19:18 +01:00
#82121 Dyntopo Improvements In Sculpt-Dev
Julien Kaspar removed a dependency 2023-02-09 22:19:24 +01:00
#82121 Dyntopo Improvements In Sculpt-Dev
Brecht Van Lommel added this to the Video Sequencer project 2023-02-13 09:12:50 +01:00
Sergey Sharybin approved these changes 2023-02-13 16:48:36 +01:00
Sergey Sharybin left a comment
Owner
Copy Link

There is compilation warning which would need to be resolves. Don't think it work an extra iteraiton though.

There is compilation warning which would need to be resolves. Don't think it work an extra iteraiton though.
source/blender/sequencer/intern/strip_retiming.cc
@ -0,0 +132,4 @@
const SeqRetimingHandle *next_handle = previous_handle + 1;
const int previous_handle_index = previous_handle - seq->retiming_handles;
BLI_assert(previous_handle_index < seq->retiming_handle_num);
Sergey Sharybin commented 2023-02-13 16:47:05 +01:00
Owner
Copy Link

Add UNUSED_VARS_NDEBUG(previous_handle_index) to solve the

[947/1084] Building CXX object source/blender/sequencer/CMakeFiles/bf_sequencer.dir/intern/strip_retiming.cc.o
/Users/sergey/Developer/blender/blender/source/blender/sequencer/intern/strip_retiming.cc:133:13: warning: unused variable 'previous_handle_index' [-Wunused-variable]
  const int previous_handle_index = previous_handle - seq->retiming_handles;
Add `UNUSED_VARS_NDEBUG(previous_handle_index)` to solve the ``` [947/1084] Building CXX object source/blender/sequencer/CMakeFiles/bf_sequencer.dir/intern/strip_retiming.cc.o /Users/sergey/Developer/blender/blender/source/blender/sequencer/intern/strip_retiming.cc:133:13: warning: unused variable 'previous_handle_index' [-Wunused-variable] const int previous_handle_index = previous_handle - seq->retiming_handles; ```
Richard Antalik added 2 commits 2023-02-15 00:40:09 +01:00
buildbot/vexp-code-patch-coordinator Build done. Details
e2042ab55d Fix crash on NULL dereference
Richard Antalik commented 2023-02-15 00:43:08 +01:00
Author
Member
Copy Link

Should have tested builds here, so
@blender-bot build

Should have tested builds here, so @blender-bot build
Richard Antalik added 1 commit 2023-02-15 01:45:34 +01:00
Richard Antalik added 1 commit 2023-02-21 13:25:09 +01:00
buildbot/vexp-code-patch-coordinator Build done. Details
b34ca86766 Revert removal of speed factor for sound strips
Sergey Sharybin commented 2023-02-21 13:45:44 +01:00
Owner
Copy Link

@blender-bot build

@blender-bot build
Richard Antalik commented 2023-02-23 15:04:41 +01:00
Author
Member
Copy Link

Committed in e1f6587f12, closing

Committed in e1f6587f12f127b9a59fa35d6e5977fda2449a2b, closing
Richard Antalik closed this pull request 2023-02-23 15:04:42 +01:00
Richard Antalik deleted branch retiming-tool 2023-02-23 15:05:08 +01:00
Julien Kaspar commented 2023-02-23 15:55:51 +01:00
Member
Copy Link

@iss Is there a plan/design for the feature? I tried it and it works pretty well.
Some things I observed though:

  • It's not easy to reset a retimed segment of a strip back to 100% speed
  • The tool does not work for audio strips. These should ideally be synched with the retiming of movie strips
  • The general speed value overlay should stay visible, even when the tool isn't active.
@iss Is there a plan/design for the feature? I tried it and it works pretty well. Some things I observed though: - It's not easy to reset a retimed segment of a strip back to 100% speed - The tool does not work for audio strips. These should ideally be synched with the retiming of movie strips - The general speed value overlay should stay visible, even when the tool isn't active.
Richard Antalik commented 2023-02-23 16:10:54 +01:00
Author
Member
Copy Link

@iss Is there a plan/design for the feature? I tried it and it works pretty well.
Thanks for feedback! Some plans are outlined in #100337

Some things I observed though:

  • It's not easy to reset a retimed segment of a strip back to 100% speed

Presets for pre-defined speeds was discussed, So this should be implemented either via dropdown menu somehow. Currently these are only gizmos, and I am not sure whether calling menu is even possible at this point. Perhaps it would be possible to hack in this functionality via context menu and some sort of segment selection.

  • The tool does not work for audio strips. These should ideally be synched with the retiming of movie strips

Implemented in #105072, needs review still.

  • The general speed value overlay should stay visible, even when the tool isn't active.

What @fsiddi suggested is to have these overlays(gizmos) always visible. Personally I think that just labels visible would be quite noisy, but perhaps I could make 2 sets of gizmos, where elements would be visually "attenuated" and inactive. These elements do require strip to be active in order to work properly, since they don't change any data. They do only call operators.

> @iss Is there a plan/design for the feature? I tried it and it works pretty well. Thanks for feedback! Some plans are outlined in #100337 > Some things I observed though: > - It's not easy to reset a retimed segment of a strip back to 100% speed Presets for pre-defined speeds was discussed, So this should be implemented either via dropdown menu somehow. Currently these are only gizmos, and I am not sure whether calling menu is even possible at this point. Perhaps it would be possible to hack in this functionality via context menu and some sort of segment selection. > - The tool does not work for audio strips. These should ideally be synched with the retiming of movie strips Implemented in #105072, needs review still. > - The general speed value overlay should stay visible, even when the tool isn't active. What @fsiddi suggested is to have these overlays(gizmos) always visible. Personally I think that just labels visible would be quite noisy, but perhaps I could make 2 sets of gizmos, where elements would be visually "attenuated" and inactive. These elements do require strip to be active in order to work properly, since they don't change any data. They do only call operators.
Francesco Siddi commented 2023-02-24 11:45:43 +01:00
Member
Copy Link
  • The general speed value overlay should stay visible, even when the tool isn't active.

What @fsiddi suggested is to have these overlays(gizmos) always visible. Personally I think that just labels visible would be quite noisy, but perhaps I could make 2 sets of gizmos, where elements would be visually "attenuated" and inactive. These elements do require strip to be active in order to work properly, since they don't change any data. They do only call operators.

Just showing the speed label would be enough, I think.

> > > - The general speed value overlay should stay visible, even when the tool isn't active. > > What @fsiddi suggested is to have these overlays(gizmos) always visible. Personally I think that just labels visible would be quite noisy, but perhaps I could make 2 sets of gizmos, where elements would be visually "attenuated" and inactive. These elements do require strip to be active in order to work properly, since they don't change any data. They do only call operators. > Just showing the speed label would be enough, I think.
Some checks failed
buildbot/vexp-code-patch-coordinator Build done.
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Sergey Sharybin
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Video Sequencer
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104544
No description provided.
Delete Branch "iss:retiming-tool"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?