VSE: Add retiming tool #104544

Richard Antalik · 2023-02-09T21:24:58+01:00

Richard Antalik commented

2023-02-09 21:24:58 +01:00

This tools allows to change strip playback speed by manipulating
retiming handles. More handles can be added to single strip to create
variable playback speed.

This tool replaces Speed Factor property in time panel.

This tools allows to change strip playback speed by manipulating retiming handles. More handles can be added to single strip to create variable playback speed. This tool replaces Speed Factor property in time panel.

Richard Antalik added 1 commit 2023-02-09 21:25:00 +01:00

VSE: Add retiming tool 0859cfbd50

This tools allows to change strip playback speed by manipulating
retiming handles. More handles can be added to single strip to create
variable playback speed.

This tool replaces Speed Factor property in time panel.

Richard Antalik requested review from Sergey Sharybin 2023-02-09 21:25:19 +01:00

Julien Kaspar added a new dependency 2023-02-09 22:19:18 +01:00

#82121 Dyntopo Improvements In Sculpt-Dev

Julien Kaspar removed a dependency 2023-02-09 22:19:24 +01:00

#82121 Dyntopo Improvements In Sculpt-Dev

Brecht Van Lommel added this to the Video Sequencer project 2023-02-13 09:12:50 +01:00

Sergey Sharybin approved these changes 2023-02-13 16:48:36 +01:00

Sergey Sharybin left a comment

There is compilation warning which would need to be resolves. Don't think it work an extra iteraiton though.

source/blender/sequencer/intern/strip_retiming.cc

						
				@ -0,0 +132,4 @@

				  const SeqRetimingHandle *next_handle = previous_handle + 1;

				  const int previous_handle_index = previous_handle - seq->retiming_handles;

				  BLI_assert(previous_handle_index < seq->retiming_handle_num);

Sergey Sharybin commented

2023-02-13 16:47:05 +01:00

Add UNUSED_VARS_NDEBUG(previous_handle_index) to solve the

[947/1084] Building CXX object source/blender/sequencer/CMakeFiles/bf_sequencer.dir/intern/strip_retiming.cc.o
/Users/sergey/Developer/blender/blender/source/blender/sequencer/intern/strip_retiming.cc:133:13: warning: unused variable 'previous_handle_index' [-Wunused-variable]
  const int previous_handle_index = previous_handle - seq->retiming_handles;

Add `UNUSED_VARS_NDEBUG(previous_handle_index)` to solve the ``` [947/1084] Building CXX object source/blender/sequencer/CMakeFiles/bf_sequencer.dir/intern/strip_retiming.cc.o /Users/sergey/Developer/blender/blender/source/blender/sequencer/intern/strip_retiming.cc:133:13: warning: unused variable 'previous_handle_index' [-Wunused-variable] const int previous_handle_index = previous_handle - seq->retiming_handles; ```

Richard Antalik added 2 commits 2023-02-15 00:40:09 +01:00

Fix compilation warning 03c5ee0294

Fix crash on NULL dereference

buildbot/vexp-code-patch-coordinator Build done.

Details

e2042ab55d

Richard Antalik commented

2023-02-15 00:43:08 +01:00

Should have tested builds here, so
@blender-bot build

Should have tested builds here, so @blender-bot build

Richard Antalik added 1 commit 2023-02-15 01:45:34 +01:00

Fix redundant redeclaration warning 6b25ac1854

Richard Antalik referenced this pull request from iss/blender

2023-02-17 01:35:47 +01:00

VSE: Add sound strip retiming support #2

Richard Antalik added 1 commit 2023-02-21 13:25:09 +01:00

Revert removal of speed factor for sound strips

buildbot/vexp-code-patch-coordinator Build done.

Details

b34ca86766

Sergey Sharybin commented

2023-02-21 13:45:44 +01:00

@blender-bot build

Richard Antalik referenced this pull request

2023-02-22 13:35:09 +01:00

VSE: Add sound strip retiming support #105071

Richard Antalik referenced this issue from a commit

2023-02-22 13:56:54 +01:00

VSE: Add sound strip retiming support

~~Richard Antalik referenced this pull request 2023-02-22 13:58:30 +01:00~~

VSE: Add sound strip retiming support #105072

Richard Antalik commented

2023-02-23 15:04:41 +01:00

Committed in e1f6587f12, closing

Committed in e1f6587f12f127b9a59fa35d6e5977fda2449a2b, closing

Richard Antalik closed this pull request

2023-02-23 15:04:42 +01:00

Richard Antalik deleted branch retiming-tool

2023-02-23 15:05:08 +01:00

Julien Kaspar commented

2023-02-23 15:55:51 +01:00

@iss Is there a plan/design for the feature? I tried it and it works pretty well.
Some things I observed though:

It's not easy to reset a retimed segment of a strip back to 100% speed
The tool does not work for audio strips. These should ideally be synched with the retiming of movie strips
The general speed value overlay should stay visible, even when the tool isn't active.

@iss Is there a plan/design for the feature? I tried it and it works pretty well. Some things I observed though: - It's not easy to reset a retimed segment of a strip back to 100% speed - The tool does not work for audio strips. These should ideally be synched with the retiming of movie strips - The general speed value overlay should stay visible, even when the tool isn't active.

Richard Antalik commented

2023-02-23 16:10:54 +01:00

@iss Is there a plan/design for the feature? I tried it and it works pretty well.
Thanks for feedback! Some plans are outlined in #100337

Some things I observed though:

It's not easy to reset a retimed segment of a strip back to 100% speed

Presets for pre-defined speeds was discussed, So this should be implemented either via dropdown menu somehow. Currently these are only gizmos, and I am not sure whether calling menu is even possible at this point. Perhaps it would be possible to hack in this functionality via context menu and some sort of segment selection.

The tool does not work for audio strips. These should ideally be synched with the retiming of movie strips

Implemented in #105072, needs review still.

The general speed value overlay should stay visible, even when the tool isn't active.

What @fsiddi suggested is to have these overlays(gizmos) always visible. Personally I think that just labels visible would be quite noisy, but perhaps I could make 2 sets of gizmos, where elements would be visually "attenuated" and inactive. These elements do require strip to be active in order to work properly, since they don't change any data. They do only call operators.

> @iss Is there a plan/design for the feature? I tried it and it works pretty well. Thanks for feedback! Some plans are outlined in #100337 > Some things I observed though: > - It's not easy to reset a retimed segment of a strip back to 100% speed Presets for pre-defined speeds was discussed, So this should be implemented either via dropdown menu somehow. Currently these are only gizmos, and I am not sure whether calling menu is even possible at this point. Perhaps it would be possible to hack in this functionality via context menu and some sort of segment selection. > - The tool does not work for audio strips. These should ideally be synched with the retiming of movie strips Implemented in #105072, needs review still. > - The general speed value overlay should stay visible, even when the tool isn't active. What @fsiddi suggested is to have these overlays(gizmos) always visible. Personally I think that just labels visible would be quite noisy, but perhaps I could make 2 sets of gizmos, where elements would be visually "attenuated" and inactive. These elements do require strip to be active in order to work properly, since they don't change any data. They do only call operators.

Francesco Siddi commented

2023-02-24 11:45:43 +01:00

The general speed value overlay should stay visible, even when the tool isn't active.

What @fsiddi suggested is to have these overlays(gizmos) always visible. Personally I think that just labels visible would be quite noisy, but perhaps I could make 2 sets of gizmos, where elements would be visually "attenuated" and inactive. These elements do require strip to be active in order to work properly, since they don't change any data. They do only call operators.

Just showing the speed label would be enough, I think.

> > > - The general speed value overlay should stay visible, even when the tool isn't active. > > What @fsiddi suggested is to have these overlays(gizmos) always visible. Personally I think that just labels visible would be quite noisy, but perhaps I could make 2 sets of gizmos, where elements would be visually "attenuated" and inactive. These elements do require strip to be active in order to work properly, since they don't change any data. They do only call operators. > Just showing the speed label would be enough, I think.

buildbot/vexp-code-patch-coordinator Build done.

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE: Add retiming tool #104544

Pull request closed