Fix #109662: Always use zero for retopology min offset when disabled #109658

Merged
Clément Foucault merged 1 commits from bonj/blender:fix/retopology-overlay-min-offset into main 2023-07-11 12:05:59 +02:00
Contributor

Using 0.0015f as minimum value on Apple makes sense when the retopology overlay is enabled.
When disabled however, this will cause the shader to think the overlay is enabled when it's not, affecting the color of faces.
Therefore the offset when disabled should always be zero.
I've removed the unnecessary define and shortened the name of the other one.

Using 0.0015f as minimum value on Apple makes sense when the retopology overlay is enabled. When disabled however, this will cause the shader to think the overlay is enabled when it's not, affecting the color of faces. Therefore the offset when disabled should always be zero. I've removed the unnecessary define and shortened the name of the other one.
Jorijn de Graaf added 1 commit 2023-07-03 17:47:48 +02:00
5da876190f Always use zero for retopology min offset when disabled
Using 0.0015f as minimum value on Apple makes sense when the retopology overlay is enabled.
When disabled however, this will cause the shader to think the overlay is enabled when it's not, affecting the color of faces.
Therefore the offset when disabled should always be zero.
I've removed the unnecessary define and shortened the name of the other one.
Author
Contributor

I don't have an Apple machine so I can't confirm whether the faulty code actually causes issues there, but I do think my logic is sound.
And for what it's worth, setting OVERLAY_RETOPOLOGY_MIN_OFFSET_DISABLED to FLT_EPSILON instead of zero does cause the described issue on my Windows machine.
I figure nobody has reported this yet because it's a pretty subtle blue, and there probably aren't that many Apple users either I guess.

I don't have an Apple machine so I can't confirm whether the faulty code actually causes issues there, but I do think my logic is sound. And for what it's worth, setting `OVERLAY_RETOPOLOGY_MIN_OFFSET_DISABLED` to `FLT_EPSILON` instead of zero does cause the described issue on my Windows machine. I figure nobody has reported this yet because it's a pretty subtle blue, and there probably aren't that many Apple users either I guess.
Jorijn de Graaf requested review from Jeroen Bakker 2023-07-03 17:55:08 +02:00
Jorijn de Graaf requested review from Clément Foucault 2023-07-03 17:55:08 +02:00
Jorijn de Graaf changed title from Always use zero for retopology min offset when disabled to Fix #109662: Always use zero for retopology min offset when disabled 2023-07-03 18:04:50 +02:00
Jorijn de Graaf requested review from William Reynish 2023-07-03 21:15:13 +02:00
Jeroen Bakker approved these changes 2023-07-10 08:04:39 +02:00
Member

I will poke William if he can test this fix. I wasn't able to reproduce any issues on my system so far.

I will poke William if he can test this fix. I wasn't able to reproduce any issues on my system so far.
Jeroen Bakker added this to the 3.6 LTS milestone 2023-07-10 08:05:37 +02:00
Jeroen Bakker added the
Module
EEVEE & Viewport
label 2023-07-10 08:05:44 +02:00
Jeroen Bakker added this to the EEVEE & Viewport project 2023-07-10 08:05:48 +02:00
Clément Foucault approved these changes 2023-07-10 11:59:47 +02:00
Clément Foucault merged commit d3315422ae into main 2023-07-11 12:05:59 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109658
No description provided.