WIP : animation name search change by name of collection for search #109786

Gangneron · 2023-07-06T16:05:42+02:00

Gangneron commented

2023-07-06 16:05:42 +02:00

First-time contributor

proposed change to search nla animations. The goal is to replace in the search bar of the nla editor the animation name with the collection name of the object.

Gangneron added 1 commit 2023-07-06 16:05:49 +02:00

a9b9741a71 Téléverser vers blender/source/blender/editors/space_nla

proposed change to search nla animations. The goal is to replace in the search bar of the nla editor the animation name with the collection name of the object.

Gangneron added 1 commit 2023-07-06 16:08:15 +02:00

06556fe6ad Téléverser vers blender/source/blender/editors/space_nla

Cleanup format

Gangneron added 1 commit 2023-07-06 16:11:52 +02:00

2ff7fefc29 Téléverser vers blender/source/blender/editors/space_nla

removed regionbase for Collection

Gangneron commented

2023-07-06 16:13:17 +02:00

First-time contributor

@BClark

Gangneron commented

2023-07-06 16:14:39 +02:00

First-time contributor

the first upload is bad because I saved as and replaced the files. It's a mistake on my part

Gangneron commented

2023-07-06 16:15:08 +02:00

First-time contributor

@dr.sybren

Sybren A. Stüvel commented

2023-07-10 15:19:09 +02:00

Please follow the ingredients of a pull request, and make sure the PR title is in English.

Please follow the [ingredients of a pull request](https://wiki.blender.org/wiki/Process/Contributing_Code#Ingredients_of_a_Pull_Request), and make sure the PR title is in English.

Gangneron commented

2023-07-10 18:11:44 +02:00

First-time contributor

Ok sorry I changed the title.
But is it that my changed are good for the moment or no

Ok sorry I changed the title. But is it that my changed are good for the moment or no

Gangneron changed title from ~~Téléverser vers blender/source/blender/editors/space_nla~~ to Upload to blender/source/blender/editors/space_nla

2023-07-10 18:15:14 +02:00

Sybren A. Stüvel commented

2023-07-11 13:58:15 +02:00

Your commit changes every single line of the file, so it's very hard to comment on what you've been doing. Please take some time to present the work clearly, so that it can be understood without much effort.

Gangneron commented

2023-07-11 14:03:11 +02:00

First-time contributor

I will closed the commit and I will create one other commit if you agree.

Sybren A. Stüvel commented

2023-07-11 14:30:13 +02:00

Please do not close this PR, you can just push more commits to the same branch, and it'll update the PR automatically.

Please do **not** close this PR, you can just push more commits to the same branch, and it'll update the PR automatically.

Damien Picard commented

2023-07-12 21:16:00 +02:00

Your formatting issues are the same as those from the duplicated PR at !109173, !109200 and !109759. I believe the main problem is not using git to create and push the commits. Again, I strongly suggest learning at least the basics of git.

Sybren A. Stüvel commented

2023-07-13 15:44:20 +02:00

I think it's more an issue of not having auto-formatting with Clang-Format set up in your IDE. Alternatively, just run make format before committing.

I think it's more an issue of not having auto-formatting with Clang-Format set up in your IDE. Alternatively, just run `make format` before committing.

Gangneron changed title from ~~Upload to blender/source/blender/editors/space_nla~~ to WIP : animation name search change by name of collection for search

2023-07-18 10:31:15 +02:00

Gangneron added 1 commit 2023-07-18 11:41:00 +02:00

8b63863c08 Reset spaca_nla file

Gangneron added 1 commit 2023-07-18 13:46:47 +02:00

8070cdaa54 change file extension to correct extension

the space_nla.c file is replaced by the correct version, i.e. space_nla.cc, which includes a change made at the level of the following PR 69aee8ba6b

Gangneron added 1 commit 2023-07-18 13:54:27 +02:00

8dd3f930ea animation name search change by name of collection for search on correct file

the file change includes the addition of the collection system to have the name of the object and to be able to search by collection name the objects.

Gangneron added 1 commit 2023-09-11 19:06:54 +02:00

76c47ea054 Delete Space_nla.c

Gangneron added 1 commit 2023-09-11 20:21:55 +02:00

74aee17af4 Add search system for nla editor

This pr adds the initialization of collections as well as a search system. The "LISTEBASE_FOREATCH" comes from the file versionning_400.cc and the initialization system comes from the file object_collection.c. The goal is to be able to search nla animations by collection name.

Gangneron added 1 commit 2023-10-01 12:14:13 +02:00

efe9ec08b5 Change system of search

changed system of search an replace old system for identique system than in interface region search

Gangneron closed this pull request

2023-10-01 12:17:03 +02:00

Gangneron deleted branch Space_nla

2023-11-22 18:09:07 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP : animation name search change by name of collection for search #109786

Pull request closed