WIP: incorrect_language_in_the_menu #109173

Gangneron · 2023-06-20T21:16:25+02:00

Gangneron commented

2023-06-20 21:16:25 +02:00

First-time contributor

fixed all problem of transaltion for Language names may be incorrect in the language menu #105461

settings.py

26 KiB

languages

2.6 KiB

Gangneron added 18 commits 2023-06-20 21:18:07 +02:00

a65ac095da WIP : GPv3 : Select circle operator

modification requested on #108662 obedit_circle_select and creation  of function  grease_pensil_circle_select as well as creation of case OB_GREASE_PENSIL.

eae7599128 WIP : GPv3 Select circle operator

modification requested on #108662 obedit_circle_select and creation  of function  grease_pensil_circle_select as well as creation of case OB_GREASE_PENSIL.

c734dcbb9d Supprimer source/blender/editors/space_view3d/view3d_select

a544da4d8b Téléverser vers blender/source/blender/editors/space_view3d

change from ed::curves::select_box to ed::curves::select_circle

dbe0b3eb50 blender/source/blender/editors/space_view3d

fixed do_grease_pensil_box_select and added ed::curves::select_circle to OB_GREASE_PENSIL for obedit_circle_select

0cdbf8bf22 blender/source/blender/editors/space_view3d

fix all problem

0a7a95e7de Téléverser vers blender/source/blender/editors/space_view3d

the compilation problem could not be resolved, however corrections have been made. I await your reply. Sorry for my inefficiency

cc4fe3e6d2 Téléverser vers blender/source/blender/editors/space_view3d

added static after int for case OB_GREASE_PENCIL

0a638e3c79 Téléverser vers blender/source/blender/editors/space_view3d

fix ever issue but compilation problem is always present

4cc73a1efe Téléverser vers blender/source/blender/editors/space_view3d

ccd2c9c615 blender/source/blender/editors/space_view3d

d6dfc7aeeb Téléverser vers blender/source/blender/editors/space_view3d

61c4670863 blender/source/blender/editors/space_view3d

e4e4ce0516 Téléverser vers blender/script/modules/bl_i18n_utils/settings.py

Language names may be incorrect in the language menu #105461 fixed in settings.py

12f76b61d2 blender/script/modules/bl_i18n_utils/settings.py

47e3936cd8 blender/script/modules/bl_i18n_utils/settings.py

fixed all problem

3e09bde7db Téléverser vers blender/script/modules/bl_i18n_utils/settings.py

23e6671177 Téléverser vers blender/script/modules/bl_i18n_utils/settings.py

Gangneron closed this pull request

2023-06-20 21:19:38 +02:00

Gangneron reopened this pull request

2023-06-20 21:29:00 +02:00

Damien Picard commented

2023-06-20 22:21:25 +02:00

Hi, thanks for the PR. When compared to the base (main in this case), the branch should only contain the commit introducing the expected changes. In your branch incorrect_language_in_the_menu, there are many unrelated commits. You could remove them using git’s interactive rebase and then force push to your branch, revert them and then redo your changes, or start a fresh branch from main (probably the easier way).

Anyway, I was able to have a look at you changes. It basically fixes all the issues I noted in #105461. However the reason I haven’t fixed them myself is that I don’t speak those languages and I want to have feedback from people who actually speak the language, instead of just relying on information found on the Internet that could be wrong. This happened for instance with Estonian: I thought it was Eesti, but it turned out to be Eesti keel.

So my question is: do you really have a very good proficiency for all of these languages? If not, I’d rather wait until we get confirmations from native or at least very proficient speakers, because introducing a new error gives no benefit over the current situation.

Hi, thanks for the PR. When compared to the base (`main` in this case), the branch should only contain the commit introducing the expected changes. In your branch `incorrect_language_in_the_menu`, there are many unrelated commits. You could remove them using git’s interactive rebase and then force push to your branch, revert them and then redo your changes, or start a fresh branch from `main` (probably the easier way). Anyway, I was able to have a look at you changes. It basically fixes all the issues I noted in #105461. However the reason I haven’t fixed them myself is that I don’t speak those languages and I want to have feedback from people who actually speak the language, instead of just relying on information found on the Internet that could be wrong. This happened for instance with Estonian: I thought it was *Eesti*, but it turned out to be *Eesti keel*. So my question is: do you really have a very good proficiency for all of these languages? If not, I’d rather wait until we get confirmations from native or at least very proficient speakers, because introducing a new error gives no benefit over the current situation.

Gangneron commented

2023-06-21 06:32:41 +02:00

First-time contributor

For my part, I do not speak any of its languages. However, I think we can do an update and add new fixes afterwards if necessary, because that way we can get direct feedback from anyone who hasn't seen this PR. I have no problem to worry about any updates, you just have to mention me so that I know.