Téléverser vers blender/script/modules/bl_i18n_utils #109200

Closed
Gangneron wants to merge 4 commits from (deleted):incorrect_language_for_menu into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
First-time contributor

No response

_No response_
2.6 KiB
Gangneron added 1 commit 2023-06-21 12:45:52 +02:00
Gangneron added 1 commit 2023-06-21 12:46:22 +02:00
Gangneron added 1 commit 2023-06-21 13:04:17 +02:00
Iliya Katushenock added the
Interest
Translations
label 2023-06-21 13:04:44 +02:00
Gangneron added 1 commit 2023-06-21 13:39:56 +02:00
Member

Hi, thank you but there are still issues with this PR:

  • The title does not describe what this does.
  • You haven’t added any description to the pull request.
  • You haven’t closed the other PR that this one replaces.
  • All lines have changed in locale/languages, as can be seen from the diff (the Files Changed tab at the top of this page). I haven’t checked out the change but I suspect it’s a line ending issue, probably using DOS line endings when Blender uses UNIX.
  • You added a duplicate file: script/modules/bl_i18n_utils/settings.py (the existing file was in scripts with an s).

If you haven’t already, please read this page on the wiki.

I’m guessing you are using this web interface, Gitea, to upload your changes. While this works in theory, it can lead to this kind of issues so I strongly advise you to learn git if you haven’t already. It would at least help solve the line ending and file renaming issues.


In addition, I still don’t agree with the basic premise of this PR, but since I am not the one who can approve or reject it since I can’t merge pull requests, my opinion may not be so important. Anyway, I’ll still explain it below.

In #109173, I wrote:

the reason I haven’t fixed them myself is that I don’t speak those languages and I want to have feedback from people who actually speak the language, instead of just relying on information found on the Internet that could be wrong. This happened for instance with Estonian: I thought it was Eesti, but it turned out to be Eesti keel.

So my question is: do you really have a very good proficiency for all of these languages? If not, I’d rather wait until we get confirmations from native or at least very proficient speakers, because introducing a new error gives no benefit over the current situation.

And you replied:

For my part, I do not speak any of its languages. However, I think we can do an update and add new fixes afterwards if necessary, because that way we can get direct feedback from anyone who hasn't seen this PR. I have no problem to worry about any updates, you just have to mention me so that I know.

To me, making a change hoping for it to draw attention to it even if it may be wrong is a bad approach. The right one would be in my opinion to reach out to users or developers, maybe through the devtalk or Blender Artists forums, and get confirmation from actual speakers that the change is actually an improvement. The reason I haven’t is that I had already tried through blender.chat, and I didn’t consider this a very urgent change. But feel free to do it if you believe it’s worth it.

Hi, thank you but there are still issues with this PR: - The title does not describe what this does. - You haven’t added any description to the pull request. - You haven’t closed the other PR that this one replaces. - All lines have changed in locale/languages, as can be seen from the diff (the _Files Changed_ tab at the top of this page). I haven’t checked out the change but I suspect it’s a line ending issue, probably using DOS line endings when Blender uses UNIX. - You added a duplicate file: script/modules/bl_i18n_utils/settings.py (the existing file was in script***s*** with an `s`). If you haven’t already, please read [this page](https://wiki.blender.org/wiki/Process/Contributing_Code) on the wiki. I’m guessing you are using this web interface, Gitea, to upload your changes. While this works in theory, it can lead to this kind of issues so I strongly advise you to learn [git]( https://wiki.blender.org/w/index.php?title=Tools/Git) if you haven’t already. It would at least help solve the line ending and file renaming issues. --- In addition, I still don’t agree with the basic premise of this PR, but since I am not the one who can approve or reject it since I can’t merge pull requests, my opinion may not be so important. Anyway, I’ll still explain it below. In #109173, I wrote: > the reason I haven’t fixed them myself is that I don’t speak those languages and I want to have feedback from people who actually speak the language, instead of just relying on information found on the Internet that could be wrong. This happened for instance with Estonian: I thought it was Eesti, but it turned out to be Eesti keel. > So my question is: do you really have a very good proficiency for all of these languages? If not, I’d rather wait until we get confirmations from native or at least very proficient speakers, because introducing a new error gives no benefit over the current situation. And you replied: > For my part, I do not speak any of its languages. However, I think we can do an update and add new fixes afterwards if necessary, because that way we can get direct feedback from anyone who hasn't seen this PR. I have no problem to worry about any updates, you just have to mention me so that I know. To me, making a change hoping for it to draw attention to it even if it may be wrong is a bad approach. The right one would be in my opinion to reach out to users or developers, maybe through the devtalk or Blender Artists forums, and get confirmation from actual speakers that the change is actually an improvement. The reason I haven’t is that I had already tried through blender.chat, and I didn’t consider this a very urgent change. But feel free to do it if you believe it’s worth it.
Gangneron closed this pull request 2023-07-05 20:34:52 +02:00
Gangneron reopened this pull request 2023-07-05 20:57:54 +02:00
Author
First-time contributor

@pioverfour i create new PR but i have one problem
#109759

@pioverfour i create new PR but i have one problem https://projects.blender.org/blender/blender/pulls/109759
Gangneron closed this pull request 2023-07-08 11:24:18 +02:00
Gangneron reviewed 2023-08-16 12:24:42 +02:00
@ -0,0 +1,737 @@
# SPDX-License-Identifier: GPL-2.0-or-later
Author
First-time contributor

delete file

delete file
Gangneron deleted branch incorrect_language_for_menu 2023-11-22 18:10:05 +01:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109200
No description provided.