Fix #40059: Use Modifier Keys Between Windows on Win32 #110020

Harley Acheson · 2023-07-12T19:12:34+02:00

Harley Acheson commented

2023-07-12 19:12:34 +02:00

Use modifier keys that are pressed before activating a new window.
Allows call of wm_window_update_eventstate_modifiers on
GHOST_kEventWindowActivate by using GetAsyncKeyState instead of
GetKeyState in GHOST_SystemWin32::getModifierKeys, which retrieves
actual hardware state.

Following shows continuously holding shift and and then ctrl while activating different windows, and properly performing pan and zoom:

This also works correctly when using Alt-Tab to select between apps, without the "stuck key" described in #105381

NOTE: This will probably be merged without a noted reviewer. This is because this PR is a change broken out of #109991. That PR included this functionality when it was approved by @ideasman42

Use modifier keys that are pressed before activating a new window. Allows call of `wm_window_update_eventstate_modifiers` on `GHOST_kEventWindowActivate` by using `GetAsyncKeyState` instead of `GetKeyState` in GHOST_SystemWin32::getModifierKeys, which retrieves actual hardware state. --- Following shows continuously holding shift and and then ctrl while activating different windows, and properly performing pan and zoom: ![Win32Modifiers.gif](/attachments/33776240-b3f8-46d6-859e-d1f8cf5f6681) This also works correctly when using Alt-Tab to select between apps, without the "stuck key" described in #105381 NOTE: This will probably be merged without a noted reviewer. This is because this PR is a change broken out of #109991. That PR included this functionality when it was approved by @ideasman42

Win32Modifiers.gif

2.0 MiB

❤️ 1 🎉 1 🚀 1

Harley Acheson added 1 commit 2023-07-12 19:12:45 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

47592d6907 Fix #40059 : Use Modifier Keys Between Windows on Win32

Use modifier keys that are pressed before activating a new window.
Allows call of `wm_window_update_eventstate_modifiers` on
`GHOST_kEventWindowActivate` by using `GetAsyncKeyState` instead of
`GetKeyState` in GHOST_SystemWin32::getModifierKeys, which retrieves
actual hardware state.

Harley Acheson added this to the Platforms, Builds Tests & Devices project 2023-07-12 19:13:02 +02:00

Harley Acheson commented

2023-07-12 19:16:11 +02:00

@blender-bot build windows

Harley Acheson merged commit b7a119c785 into main

2023-07-12 20:01:43 +02:00

Harley Acheson deleted branch Win32WindowModifiers

2023-07-12 20:01:44 +02:00

Harley Acheson referenced this issue from a commit

2023-07-12 20:01:47 +02:00

Fix #40059: Use Modifier Keys Between Windows on Win32

Harley Acheson referenced this pull request