blender-v3.6-release backports #112328

Philipp Oeser · 2023-09-13T15:59:20+02:00

Philipp Oeser commented

2023-09-13 15:59:20 +02:00

No response

_No response_

Philipp Oeser added 7 commits 2023-09-13 15:59:29 +02:00

e039442f27 Fix #111970 : Regression: Crash with assertion after delete scene when some 3D Views have Local Collection enabled

This is a nasty gathering of several issues, main one being that 'local
collections' of 3DViews are still updated immediately instead of the
deferred update used for all other viewlayer cases.

The change in a16bcb6576 led to internal references to the Scene's
master collection to become invalid, which is the expected behavior.
But this turns the Scene's view_layers into invalid state too.

Ideally, there should never be resync of viewlayers of a scene being
deleted anyways.

For now, take the (hopefully!) safe approach of explicitely forbidding
any viewlayer update during ID deletion process, and deferring it at the
end of the process.

Note that this change may also give some marginal gerformance
improvements in some rare edge cases (like deleting a very heavy scene
with many collections and 'local collection' 3DViews ?).

8159bd90e5 Fix #111820 : Missing type casting in XrGraphicsBinding.cc

The line `oxr_binding.egl.getProcAddress = eglGetProcAddress` supposedly
needs a type casting for it to compile successfully under llvm16.

Pull Request: #111915

c6998872f0 Fix #112208 : Vertex parenting index wrong with multiple splines

Caused by 346023b457.

Above commit made variables too local (starting index with zero in each
nurb of the curve/surface object, but we need the "overall" index).

Should be good for LTS.

Pull Request: #112222

9fc217cedf Fix: Regression: Box select not working for GP/GPv3 channels

Caused by 62d9e55eec
Grease pencil channels are not added to the `anim_data` list when
`ANIMFILTER_FCURVESONLY` is set. So skip this filter-type when GP
animdata is present.

Pull Request: #111377

57a58fb2b3 Fix #112028 : Ctrl+Alt+Scroll not working on all selected objects

Regression from c51467cd4c.

Above commit made the IS_ALLSELECT_EVENT more strict and now excluded
mousewheel events.

Refining IS_ALLSELECT_EVENT even further (to respect mousewheel there)
is unfortunately not easily possible since mouswheel events are excluded
from `win->eventstate` (could only be retrieved from `win->event_queue`
but that is not reliable either since it might have events that are not
handled yet).

Possible solutions:
___
Adding mouswheel events to `win->eventstate`
- seemed to risky (could not forsee all possible consequences this would
have, e.g. double-click behavior)
___
Moving shortcuts for button array copy/paste from ALT to SHIFT
- downside: breaking user habits
- upside: additionally holding ALT could open the door for pasting on
all selected items
-- downside: without further work to make paste to multiple work better,
it would bring back #108096
___

So propose to do what was first suggested in #108270 as a third
solution:

Instead of refining IS_ALLSELECT_EVENT, bring it back to the state
before c51467cd4c (So `Ctrl + Alt + V` would still pass this test), but
specifically "filter out `Ctrl + Alt + V` right after in ui_apply_but().

Pull Request: #112095

d06c761a9d Fix #112144 : Graph Editor handle highlighting not working correctly

Mistake in 7c48196056.

Second handle was always drawn with positions of the first handle (when
it was highlighted).

Should be good for 3.6/3.3 LTS.

Pull Request: #112219

buildbot/vexp-code-patch-coordinator Build done. Details

588c793db0 Fix #112285 : Sculpt Mode: Mask brush smoothing is broken

Mistake in cc01bb83f6.

Above commit tried to be smart about early out, but wasnt.
Now corrected.

NOTE: fix needs to go into 3.6 LTS

Pull Request: #112292

Philipp Oeser commented

2023-09-13 15:59:45 +02:00

@blender-bot build

Philipp Oeser merged commit 9a2f166307 into blender-v3.6-release

2023-09-13 16:31:54 +02:00

Philipp Oeser referenced this issue from a commit

2023-09-13 16:31:54 +02:00

Fix #112285: Sculpt Mode: Mask brush smoothing is broken

Philipp Oeser deleted branch blender-v3.6-release

2023-09-13 16:31:55 +02:00

Sign in to join this conversation.

No reviewers