UI: Type To Search And Space Bar Search #113520

Harley Acheson · 2023-10-10T23:33:47+02:00

Harley Acheson commented

2023-10-10 23:33:47 +02:00

Continue allowing spacebar search for all dropdown and context menus,
but also add the ability to allow some menus to have type to search,
like Add Modifiers, Objects, Nodes.

As discussed in our UI Module Meeting, this PR adds the ability to specify that specific menus have "type to search" (by adding menu option SEARCH_ON_KEY_PRESS), while keeping the "spacebar to search" available for all regular dropdown and context menus.

This is largely just putting lots of @JacquesLucke's code back in, with some changes needed to have the two searches coexist.

One difference is that this PR adds SEARCH_ON_KEY_PRESS to the submenus of the "Add" menus. Otherwise you could search submenus with space bar but not with type to search.

Similarly the code in interface_handlers.cc is a bit different to allow more specific "pass event to parent" behavior for searches than for accelerator keys. In a nutshell if you have just opened a menu but no submenus are activated (your mouse is over the main list) we want to search the parent, not the child. However if the child is not directly searchable (without a name, probably because it is an enum menu) then search the parent because it will include the child items.

One decision taken here is that when dropdown menus are opened they all continue to show "Press spacebar to search..." even if they also have "type to search enabled". This is just because it looked odd to see the odd one show something different. It isn't wrong, in that space bar search works there of course, but it just doesn't add anything about type to search.

This PR adds a "Search" item to these menus. You can click on it to start search, but it also is an indication that this menu is different.

I think this addresses all the issues we discussed.

Continue allowing spacebar search for all dropdown and context menus, but also add the ability to allow some menus to have type to search, like Add Modifiers, Objects, Nodes. --- As discussed in our [UI Module Meeting](https://devtalk.blender.org/t/2023-10-10-user-interface-meeting/31324), this PR adds the ability to specify that specific menus have "type to search" (by adding menu option SEARCH_ON_KEY_PRESS), while keeping the "spacebar to search" available for all regular dropdown and context menus. This is largely just putting lots of @JacquesLucke's code back in, with some changes needed to have the two searches coexist. One difference is that this PR adds SEARCH_ON_KEY_PRESS to the submenus of the "Add" menus. Otherwise you could search submenus with space bar but not with type to search. Similarly the code in `interface_handlers.cc` is a bit different to allow more specific "pass event to parent" behavior for searches than for accelerator keys. In a nutshell if you have just opened a menu but no submenus are activated (your mouse is over the main list) we want to search the parent, not the child. However if the child is not directly searchable (without a name, probably because it is an enum menu) then search the parent because it will include the child items. One decision taken here is that when dropdown menus are opened they all continue to show "Press spacebar to search..." even if they also have "type to search enabled". This is just because it looked odd to see the odd one show something different. It isn't wrong, in that space bar search works there of course, but it just doesn't add anything about type to search. This PR adds a "Search" item to these menus. You can click on it to start search, but it also is an indication that this menu is different. ![image](/attachments/4195ed57-d3a2-494c-ac86-cf88542d5075) I think this addresses all the issues we discussed.

image.png

40 KiB

👍 7 👀 2 ❤️ 9 🎉 2 🚀 2

Harley Acheson added 1 commit 2023-10-10 23:34:00 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

8d6b399aa8 UI: Type To Search And Space Bar Search

Continue allowing spacebar search for all dropdown and context menus,
but also add the ability to allow some menus to have type to search,
like Add Modifiers, Objects, Nodes.

Harley Acheson changed title from ~~UI: Type To Search And Space Bar Search~~ to UI: Type To Search And Space Bar Search

2023-10-10 23:36:01 +02:00

Harley changed target branch from main to blender-v4.0-release

2023-10-10 23:36:03 +02:00

Harley Acheson added this to the User Interface project 2023-10-10 23:36:26 +02:00

Harley Acheson requested review from Jacques Lucke 2023-10-10 23:36:46 +02:00

Harley Acheson requested review from Pablo Vazquez 2023-10-10 23:36:53 +02:00

Harley Acheson requested review from Dalai Felinto 2023-10-10 23:37:11 +02:00

Harley Acheson requested review from Julian Eisel 2023-10-10 23:37:23 +02:00

Harley Acheson commented

2023-10-11 00:09:15 +02:00

@blender-bot package

Blender Bot commented

2023-10-11 00:09:17 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR113520) when ready.

Pratik Borhade referenced this pull request

2023-10-11 09:45:33 +02:00

Cannot search in modifier #113528

Jacques Lucke approved these changes 2023-10-11 10:47:24 +02:00

source/blender/editors/interface/interface_handlers.cc Outdated

						
				@ -10769,0 +10780,4 @@

				            /* Menu search if spacebar or SearchOnKeyPress. */

				            MenuType *mt = WM_menutype_find(menu->menu_idname, false);

				            if (mt && bool(mt->flag & MenuTypeFlag::SearchOnKeyPress) || event->type == EVT_SPACEKEY) {

Jacques Lucke commented

2023-10-11 10:41:03 +02:00

/home/jacques/blender/blender/source/blender/editors/interface/interface_handlers.cc: In function ‘int ui_handle_menu_event(bContext*, const wmEvent*, uiPopupBlockHandle*, int, bool, bool, bool)’:
/home/jacques/blender/blender/source/blender/editors/interface/interface_handlers.cc:10783:20: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
10783 |             if (mt && bool(mt->flag & MenuTypeFlag::SearchOnKeyPress) || event->type == EVT_SPACEKEY) {
      |                 ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

``` /home/jacques/blender/blender/source/blender/editors/interface/interface_handlers.cc: In function ‘int ui_handle_menu_event(bContext*, const wmEvent*, uiPopupBlockHandle*, int, bool, bool, bool)’: /home/jacques/blender/blender/source/blender/editors/interface/interface_handlers.cc:10783:20: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] 10783 | if (mt && bool(mt->flag & MenuTypeFlag::SearchOnKeyPress) || event->type == EVT_SPACEKEY) { | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```

Harley marked this conversation as resolved

Daniel Gryningstjerna commented

2023-10-11 10:58:19 +02:00

First-time contributor

Thanks @Harley,
just tested the patch and it works perfectly! Seems like a great solution :) Getting the best of both worlds! Thanks again!

Thanks @Harley, just tested the patch and it works perfectly! Seems like a great solution :) Getting the best of both worlds! Thanks again!

Gerstmann Bradley commented

2023-10-11 11:09:20 +02:00

First-time contributor

I think this solution is better than previous pure spacebar search, but to me it still raises some questions.
Different people have different preferences on search Vs. accelerator key, and more importantly it's inconsistent with different behaviors in different menus.
I think since we can assign shortcut to search function. is "type to search" really necessary? If people want "type to search", they can assign shortcut to search by themselves to directly call search functions. In that case, we are giving users options to choose as they always ask for.

I think this solution is better than previous pure spacebar search, but to me it still raises some questions. Different people have different preferences on search Vs. accelerator key, and more importantly it's inconsistent with different behaviors in different menus. I think since we can assign shortcut to search function. is "type to search" really necessary? If people want "type to search", they can assign shortcut to search by themselves to directly call search functions. In that case, we are giving users options to choose as they always ask for. ![image](/attachments/2edf0a1c-26bc-4e5f-902d-3cacd34ea558)

image.png

83 KiB

Ludvik Koutny commented

2023-10-11 11:38:48 +02:00

I think this solution is better than previous pure spacebar search, but to me it still raises some questions.
Different people have different preferences on search Vs. accelerator key, and more importantly it's inconsistent with different behaviors in different menus.
I think since we can assign shortcut to search function. is "type to search" really necessary? If people want "type to search", they can assign shortcut to search by themselves to directly call search functions. In that case, we are giving users options to choose as they always ask for.

This is how it worked in 3.6 and previous but the big issue here is that this assumes only one menu per editor. So for example you would spend your type to search key on Add menu in the 3D View context, but the 4.0 idea is that all menus should be searchable.

> I think this solution is better than previous pure spacebar search, but to me it still raises some questions. > Different people have different preferences on search Vs. accelerator key, and more importantly it's inconsistent with different behaviors in different menus. > I think since we can assign shortcut to search function. is "type to search" really necessary? If people want "type to search", they can assign shortcut to search by themselves to directly call search functions. In that case, we are giving users options to choose as they always ask for. > ![image](/attachments/2edf0a1c-26bc-4e5f-902d-3cacd34ea558) > This is how it worked in 3.6 and previous but the big issue here is that this assumes only one menu per editor. So for example you would spend your type to search key on Add menu in the 3D View context, but the 4.0 idea is that all menus should be searchable.

❤️ 1

Pablo Vazquez approved these changes 2023-10-11 11:44:17 +02:00

Pablo Vazquez left a comment

Works as expected.

Thanks for tackling this one!

Works as expected. Thanks for tackling this one!

Harley Acheson added 2 commits 2023-10-11 18:37:02 +02:00

10f38a929d Merge branch 'blender-v4.0-release' of projects.blender.org:blender/blender into CombinedMenuSearch

656b337a08 Ambiguous test

Pratik Borhade referenced this pull request

2023-10-12 05:00:39 +02:00

No "Search" option in the shortcut menu in the compositor #112107