UI: Allow Some Buttons to Scale Width With Text Style #119223

Harley Acheson · 2024-03-08T20:59:38+01:00

Harley Acheson commented

2024-03-08 20:59:38 +01:00

Allow some View3D buttons to change their width according to content
and Text Styles, rather than be fixed amount of UI_UNIT_X. Examples
include "Object Mode", "Transform Orientation", "Grease Pencil Layers",
"Texture Slots", "Vertex Groups", "Attribute", etc.

It has been a long-standing complaint that some of our UI items are (seemingly) a fixed width. Our best examples are "Object Mode" and "Transform Orientations". These are always a fixed width that is only scaled by the Resolution Scale. These don't change width to match their content which is problematic for translations. Adding a custom transform orientation with a long name will cut it off. And it is also a problem for accessibility in that they do not change width with changes to Text Styles.

The root cause of this is that these items use layout->ui_units_x. This sets a fixed width in a number of UI_UNIT_X units. This is not changed with Text Styles.

Although the scaling set by layout->ui_units_x could be improved, this would still be a width that does not account for the string contents. This PR just removes the uses of layout->ui_units_x here. This results in these items scaling properly with contents, including with translations, custom items, and with changes to Text Styles.

For example, increase the Text Style font size for widgets. Above is current behavior, below is with this PR:

Allow some View3D buttons to change their width according to content and Text Styles, rather than be fixed amount of UI_UNIT_X. Examples include "Object Mode", "Transform Orientation", "Grease Pencil Layers", "Texture Slots", "Vertex Groups", "Attribute", etc. --- It has been a [long-standing complaint](https://projects.blender.org/blender/blender/issues/86974) that some of our UI items are (seemingly) a fixed width. Our best examples are "Object Mode" and "Transform Orientations". These are always a fixed width that is only scaled by the Resolution Scale. These don't change width to match their content which is problematic for translations. Adding a custom transform orientation with a long name will cut it off. And it is also a problem for accessibility in that they do not change width with changes to Text Styles. The root cause of this is that these items use layout->ui_units_x. This sets a fixed width in a number of UI_UNIT_X units. This is not changed with Text Styles. Although the scaling set by layout->ui_units_x could be improved, this would still be a width that does not account for the string contents. This PR just removes the uses of layout->ui_units_x here. This results in these items scaling properly with contents, including with translations, custom items, and with changes to Text Styles. For example, increase the Text Style font size for widgets. Above is current behavior, below is with this PR: ![image](/attachments/c16c7cff-b04d-4444-840a-c6fe09ebf912)

image.png

17 KiB

👍 5

Harley Acheson added 1 commit 2024-03-08 20:59:49 +01:00

557735082a UI: Allow Some Buttons to Scale Width With Text Style

Allow some View3D buttons to change their width according to content
and Text Styles, rather than be fixed amount of UI_UNIT_X. Examples
include "Object Mode", "Transform Orientation", "Grease Pencil Layers",
"Texture Slots", "Vertex Groups", "Attribute", etc.

Harley Acheson added this to the User Interface project 2024-03-08 21:04:23 +01:00

Harley Acheson merged commit 85762d99ef into main

2024-03-08 21:50:07 +01:00

Harley Acheson referenced this issue from a commit

2024-03-08 21:50:07 +01:00

UI: Allow Some Buttons to Scale Width With Text Style

Harley Acheson deleted branch LayoutUiUnits

2024-03-08 21:50:09 +01:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Allow Some Buttons to Scale Width With Text Style #119223