blender-v4.2-release backports #130173

Philipp Oeser · 2024-11-12T15:23:49+01:00

Philipp Oeser commented

2024-11-12 15:23:49 +01:00

No response

_No response_

Philipp Oeser added 14 commits 2024-11-12 15:24:01 +01:00

Fix #126562 : Cycles/EEVEE versioning 34b4ad4e3a

Check all scenes to decide between versioning merged settings using
EEVEE or Cycles properties.

Still far from a great solution. :(

Pull Request: #128554

Fix #128702 : Edge Slide can cause Blender to freeze da95b98b6c

In non-manifold geometry, the original loop could fail to identify the
correct slide direction because it checked for loop equality
(`l_other != l_edge`), which might never be met.

The condition has been revised to check for face equality
(`l_other->f != l_edge->f`), ensuring the loop terminates correctly and
preventing infinite iterations in problematic geometry cases.

Fix #128766 : crash dropping files with Wayland 76a26bd55f

Dropping files could crash ~10% of the time on some systems,
although I wasn't able to reproduce the error.

The ownership of GWL_Seat::data_offer_dnd wasn't handled correctly,
where the value could be handled by both wl_data_device_listener::leave
& drop callbacks.

Resolve by ensuring the data-offer is handled by the drop callback.

Fix #122635 : Precision mode not working with Snap to Grid 5aa9267bce

This introduces partial functionality of Precision mode to 'Snap to
Grid'.

However, it behaves differently from 'Absolute Grid Snap', as it lacks
smooth mouse movement.

Precision mode is now available specifically for Transform operations.

Fix: Error in previous commit: Snap to grid not updating size while navigating 18819879a4

`t->snap` varies per operator and does not update.

Fix #126665 : Reintroduce 'Absolute Grid Snap' (now 'Absolute Increment Snap') c5aad2352b

The 'Absolute Grid Snap' feature remains useful even alongside
'Snap to Grid', so this option is being reintroduced, partially
reverting commit f0479e915f.

Pull Request: #128135

Fix error in snap-grid check b99df49f6c

Correct check from 75ffda39b2.

Fix #128282 : EEVEE: Unable to compile displacement 1627240f78

When using vertex displacement EEVEE didn't compile the generated
functions into the vertex shader. This could result in errors when
compiling materials.

**Notes**

- Should be back-ported to Blender 4.2

Pull Request: #128525

Fix #128840 : extension build asserts when "type" is missing 6d54803f30

Building an extension when the manifest didn't define a "type"
would assert instead of reporting the missing field.

Return earlier when there are errors to prevent the assertion.

Fix #128838 : Extension: Support _universal2 suffix for Mac 382fb5e971

Some python wheels can have `_universal2` suffixes which are built for
both intel and arm architectures. This fix takes care of that.

Fix: Workbench: Disable overlays_enabled optimizations 8f195aa9ac

Since the `overlays_enabled` optimizations were introduced in
fe39456ba5, it has been a constant
source of bugs: #113741, #116403, #120628, #125414
There are many cases where the code expects to have the Workbench
depth available even when overlays are disabled.
So this simply disables the optimization and ensures the depth buffer is
always valid.

Pull Request: #125447

Fix: EEVEE: Point lights with zero radius create in shadow artifact 894c2909b1

This is likely caused by local_ray_up being degenerate with
very small radii. This is a temporary fix and should be revisited
later.

The issue is that the real fix is likely to have a higher
performance cost.

Fix #124636

Fix #128637 : Gizmo line tool not snapping to exactly 45 degrees b323f71696

Due to rounding errors in `wm_gesture_straightline_do_angle_snap`, it
could give out a snapped result that's meant to be 45 degrees but does
not have equal X/Y distances after converted to integer. Since 45
degrees can be used to make a equal length structure, it's best to make
sure that resulting X/Y values are the same if the angle is multiple of
45 degrees.

This fix would be effective for all tools that uses this "straight line
gizmo".

Pull Request: #128683

Fix #126983 : custom nodes and groups icon missing

buildbot/vexp-code-patch-lint Build done.

Details

buildbot/vexp-code-patch-darwin-x86_64 Build done.

Details

buildbot/vexp-code-patch-linux-x86_64 Build done.

Details

buildbot/vexp-code-patch-darwin-arm64 Build done.

Details

buildbot/vexp-code-patch-windows-amd64 Build done.

Details

buildbot/vexp-code-patch-coordinator Build done.

Details

9d6c483727

Fix regression caused by commit b120440f7c.

Pull Request: #127263

Philipp Oeser commented

2024-11-12 15:24:17 +01:00

@blender-bot build

Philipp Oeser added 1 commit 2024-11-12 15:27:30 +01:00

Cleanup: make format

buildbot/vexp-code-patch-lint Build done.

Details

buildbot/vexp-code-patch-linux-x86_64 Build done.

Details

buildbot/vexp-code-patch-darwin-arm64 Build done.

Details

buildbot/vexp-code-patch-windows-amd64 Build done.

Details

buildbot/vexp-code-patch-darwin-x86_64 Build done.

Details

buildbot/vexp-code-patch-coordinator Build done.

Details

87d2a5b679

Philipp Oeser commented

2024-11-12 15:28:14 +01:00

@blender-bot build

Philipp Oeser added 5 commits 2024-11-12 16:37:01 +01:00

Fix #126728 : Movie Clip Editor "Sync Visible Range" option not working 9dd1315cc0

True for both `Graph` and `Dopesheet` views in the MCE.

For all other time-based editors, the main region (`RGN_TYPE_WINDOW`) is
of interest to be tagged for syncing `V2D_VIEWSYNC_SCREEN_TIME`. In the
case of the Movie Clip Editor however, the `Graph` and `Dopesheet`
regions in question are of type `RGN_TYPE_PREVIEW`.

So to resolve, we have to take this into account in view2d_sync RNA code

NOTE: this PR does not add versioning code, so any "falsely" tagged
`Graph` and `Dopesheet` view will "loose" the setting (will have to be
enabled again on the "right" region), this could be added though -- it
would be impossible to tell **which**  view exactly, so on each
`RGN_TYPE_WINDOW` encountered, we'd have to then tag **both** `Graph`
and `Dopesheet` afaict

Pull Request: #126785

Fix #126869 : frame navigation keymap missing from relevant sidebars 6b71692780

Affected NLA, Dopesheet, Timeline

Region needs `ED_KEYMAP_FRAMES` flag to initialize the corresponding
"Frames" keymap.

Basically the same as cd1d6d7770 , but now also for `space_nla` &
`space_action`

Pull Request: #126918

Fix #127117 : NLA Channels missing update on animated object visibility c9ceb32f13

e420caab19 already fixed this for "manually" changing visibility, but
if this change comes through animation, these notifiers dont fire (rna
callbacks dont run).

So to resolve, also redraw on `ND_FRAME`, this is something every region
in animation editors listens to anyways, so probably right for
consistency (and to solve this bug), even though it might eat away some
ticks.

Pull Request: #127145

Fix #127180 : Outliner assert selecting unselectable editbones d7ced4b5a3

Prevent actual selection (keeping activation of the bone).

Since `buttons_context_path_bone` / `buttons_context_path_pose_bone` go
after `arm->act_bone` / `arm->act_edbone` to set the context "bone",
"pose_bone" or "edit_bone" -- and that is set no matter what in
`tree_element_bone_activate` / `tree_element_active_ebone__sel` -- we
can set the bone active, not actually select it and the Properties
Editor can still show the relevant info.

Pull Request: #127235

Fix #127399 : Sculpt temporary Smooth brush ignores some settings

buildbot/vexp-code-patch-lint Build done.

Details

buildbot/vexp-code-patch-linux-x86_64 Build done.

Details

buildbot/vexp-code-patch-darwin-x86_64 Build done.

Details

buildbot/vexp-code-patch-darwin-arm64 Build done.

Details

buildbot/vexp-code-patch-windows-amd64 Build done.

Details

buildbot/vexp-code-patch-coordinator Build done.

Details

477dfe430d

If the Smooth brush (which is switched to from other brushes holding
`Shift`) had the following settings (possibly others as well)
- Stabilize Stroke
- Airbrush
- Line
These were ignored (not drawing their correct cursor, airbrush not
working because the timer wasnt started).

Problem here is that `smooth_brush_toggle_on` (called via stroke->
test_start) changes the brush, this was ignored in following code (and
in case of the `Stabilize Stroke` is called only after the code that was
checking if this was ON).

So to resolve, get the brush again after `stroke->test_start` has run
(and also move the check `Stabilize Stroke` a bit (to  place that
actually fits much better since similar things like line visualization
are handled there as well)

Pull Request: #127412

Philipp Oeser commented

2024-11-12 16:37:28 +01:00

@blender-bot build

Philipp Oeser merged commit 5345b33fc3 into blender-v4.2-release

2024-11-13 09:19:17 +01:00

Philipp Oeser referenced this issue from a commit

2024-11-13 09:19:19 +01:00

Fix #127399: Sculpt temporary Smooth brush ignores some settings

Philipp Oeser deleted branch blender-v4.2-release

2024-11-13 09:19:22 +01:00

Sign in to join this conversation.

No reviewers